Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use glauth v2 #2656

Merged
merged 1 commit into from
Oct 21, 2021
Merged

use glauth v2 #2656

merged 1 commit into from
Oct 21, 2021

Conversation

wkloucek
Copy link
Contributor

Description

Update glauth to version 2: glauth/glauth#226

Related Issue

  • Fixes Dependabot for Go

Todo:

@update-docs
Copy link

update-docs bot commented Oct 21, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested a review from C0rby October 21, 2021 05:37
@wkloucek wkloucek marked this pull request as draft October 21, 2021 05:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek mentioned this pull request Oct 21, 2021
Closed
@C0rby
Copy link
Contributor

C0rby commented Oct 21, 2021 •
edited
Loading

It does work without the assets package? How? 🤔

@C0rby
Copy link
Contributor

C0rby commented Oct 21, 2021

Nevermind, I looked inside of the wrong branch. The dev branch does contain an assets package.

C0rby
C0rby approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Finally we can unblock the dependabot. 🎉

@wkloucek wkloucek marked this pull request as ready for review October 21, 2021 07:44
@wkloucek
Copy link
Contributor Author

We decided to merge this asap and switch to a stable tag later.

@wkloucek wkloucek merged commit bd8a799 into master Oct 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the glauth_v2 branch October 21, 2021 07:45
ownclouders pushed a commit that referenced this pull request Oct 21, 2021
@wkloucek
commit bd8a799
16f7d24 
Merge: e548894 1ccc568
Author: Willy Kloucek <[email protected]>
Date:   Thu Oct 21 09:45:08 2021 +0200

    Merge pull request #2656 from owncloud/glauth_v2

    use glauth v2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @C0rby