Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/user settings capability #2655

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Conversation

pascalwengerter
Copy link
Contributor

Description

In the web client, requests for the oCIS settings service are currently also being sent to OC10 backends. With this capability, we can make sure only to send such requests if the right service is present in the backend. Potentially, this capability could also be used by other clients to check availability of settings endpoints to e.g. handle user settings on mobile

Related Issue

Types of changes

  • New feature (non-breaking change which adds functionality)

Comment on lines +275 to +280
"settings": []map[string]interface{}{
{
"enabled": true,
"version": "1.0.0",
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just the oCIS side of capabilities. It is only used to configure REVA. Therefore to actually have it available on the endpoint you also need to add this to REVA. You can see in this PR how do that: https://github.com/cs3org/reva/pull/2088/files

Currently curl -k 'https://localhost:9200/ocs/v1.php/cloud/capabilities?format=json' -u einstein:relativity | jq . does only give me:

          "user": {
            "send_mail": true,
            "profile_picture": false
          }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay interesting, I thought we're wrapping/extending REVA's capabilities in oCIS...will add a PR there then, too

@pascalwengerter
Copy link
Contributor Author

Depends on cs3org/reva#2189 to be merged

@wkloucek wkloucek force-pushed the feat/user-settings-capability branch from c493700 to f30b5af Compare October 21, 2021 11:40
@wkloucek wkloucek self-requested a review October 21, 2021 11:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit ee7a3bf into master Oct 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/user-settings-capability branch October 21, 2021 12:13
ownclouders pushed a commit that referenced this pull request Oct 21, 2021
Merge: 5268b8e f30b5af
Author: Willy Kloucek <[email protected]>
Date:   Thu Oct 21 14:13:53 2021 +0200

    Merge pull request #2655 from owncloud/feat/user-settings-capability

    Feat/user settings capability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip oCIS-only settings request for OC10
2 participants