-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/user settings capability #2655
Conversation
"settings": []map[string]interface{}{ | ||
{ | ||
"enabled": true, | ||
"version": "1.0.0", | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just the oCIS side of capabilities. It is only used to configure REVA. Therefore to actually have it available on the endpoint you also need to add this to REVA. You can see in this PR how do that: https://github.com/cs3org/reva/pull/2088/files
Currently curl -k 'https://localhost:9200/ocs/v1.php/cloud/capabilities?format=json' -u einstein:relativity | jq .
does only give me:
"user": {
"send_mail": true,
"profile_picture": false
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay interesting, I thought we're wrapping/extending REVA's capabilities in oCIS...will add a PR there then, too
Depends on cs3org/reva#2189 to be merged |
c493700
to
f30b5af
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
In the web client, requests for the oCIS settings service are currently also being sent to OC10 backends. With this capability, we can make sure only to send such requests if the right service is present in the backend. Potentially, this capability could also be used by other clients to check availability of settings endpoints to e.g. handle user settings on mobile
Related Issue
Types of changes