Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] change default paths for oCIS services #2590

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Oct 7, 2021

Description

Acceptance Critiera from #1620

  • the default storage location can be set on compile time

  • a non default storage location can be configured with one ENV-variable / command-line-flag / config option
    -> There is currently no way to achieve that with command-line-flags or config file options

  • the default storage location is /var/lib/ocis for our docker images

  • all extensions of oCIS store their data inside /var/lib/ocis when using our docker image without changing the default storage location

  • all extensions of oCIS store their data inside ~/.ocis when using the binary release on linux without changing the default storage location

  • documentation reflects the added / changed configuration options

    image

    The default paths are rendered in an ugly way for our documentation:
    image

    But on runtime it looks fine:

    go run ./ocis/cmd/ocis idp --help
    NAME:
       ocis idp - Start idp server
    
    USAGE:
       ocis idp command [command options] [arguments...]
    
    COMMANDS:
       version  Print the versions of the running instances
       help, h  Shows a list of commands or help for one command
    
    OPTIONS:
    ...
       --transport-tls-cert value            Certificate file for transport encryption (default: "/home/kloucek/.ocis/idp/server.crt") [$IDP_TRANSPORT_TLS_CERT]
       --transport-tls-key value             Secret file for transport encryption (default: "/home/kloucek/.ocis/idp/server.key") [$IDP_TRANSPORT_TLS_KEY]
    

Related Issue

Motivation and Context

see #1620

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 7, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek self-assigned this Oct 8, 2021
@wkloucek wkloucek force-pushed the change_data_path branch 2 times, most recently from 1c51897 to 652531a Compare October 11, 2021 13:12
@wkloucek wkloucek changed the title change some paths... [full-ci] change some paths... Oct 12, 2021
@wkloucek wkloucek force-pushed the change_data_path branch 2 times, most recently from 5754232 to 2cdf68d Compare October 18, 2021 06:22
@wkloucek wkloucek changed the title [full-ci] change some paths... [full-ci] change default paths for oCIS services Oct 19, 2021
@wkloucek wkloucek marked this pull request as ready for review October 19, 2021 12:54
@wkloucek wkloucek requested review from refs, C0rby and micbar and removed request for lookacat, kulmann and pascalwengerter October 19, 2021 12:54
Copy link
Member

@refs refs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Only the 2 small code smells

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

5.9% 5.9% Coverage
12.8% 12.8% Duplication

@wkloucek wkloucek merged commit e3c52af into master Oct 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the change_data_path branch October 20, 2021 06:24
ownclouders pushed a commit that referenced this pull request Oct 20, 2021
Merge: 127db3f 24fb595
Author: Willy Kloucek <[email protected]>
Date:   Wed Oct 20 08:24:22 2021 +0200

    Merge pull request #2590 from owncloud/change_data_path

    [full-ci] change default paths for oCIS services
wkloucek added a commit that referenced this pull request Oct 27, 2021
wkloucek added a commit that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants