-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] change default paths for oCIS services #2590
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
wkloucek
force-pushed
the
change_data_path
branch
2 times, most recently
from
October 11, 2021 13:12
1c51897
to
652531a
Compare
wkloucek
force-pushed
the
change_data_path
branch
2 times, most recently
from
October 18, 2021 06:22
5754232
to
2cdf68d
Compare
wkloucek
force-pushed
the
change_data_path
branch
from
October 19, 2021 12:21
2cdf68d
to
1b19e14
Compare
wkloucek
changed the title
[full-ci] change some paths...
[full-ci] change default paths for oCIS services
Oct 19, 2021
wkloucek
force-pushed
the
change_data_path
branch
from
October 19, 2021 12:37
1b19e14
to
cddb334
Compare
wkloucek
requested review from
kulmann,
pascalwengerter and
lookacat
as code owners
October 19, 2021 12:54
wkloucek
requested review from
refs,
C0rby and
micbar
and removed request for
lookacat,
kulmann and
pascalwengerter
October 19, 2021 12:54
wkloucek
force-pushed
the
change_data_path
branch
from
October 19, 2021 13:29
4744457
to
060c093
Compare
refs
approved these changes
Oct 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. Only the 2 small code smells
Kudos, SonarCloud Quality Gate passed! |
9 tasks
wkloucek
added a commit
that referenced
this pull request
Oct 27, 2021
wkloucek
added a commit
that referenced
this pull request
Oct 27, 2021
fix accounts backend regression from #2590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Acceptance Critiera from #1620
the default storage location can be set on compile time
a non default storage location can be configured with one ENV-variable
/ command-line-flag / config option-> There is currently no way to achieve that with command-line-flags or config file options
the default storage location is
/var/lib/ocis
for our docker imagesall extensions of oCIS store their data inside
/var/lib/ocis
when using our docker image without changing the default storage locationall extensions of oCIS store their data inside
~/.ocis
when using the binary release on linux without changing the default storage locationdocumentation reflects the added / changed configuration options
The default paths are rendered in an ugly way for our documentation:
But on runtime it looks fine:
Related Issue
Motivation and Context
see #1620
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: