fix ldap CA config for docker images

[wkloucek]

Description

STORAGE_LDAP_CACERT was intruduced in #2492 and needs to be set to the same value as GLAUTH_LDAPS_CERT in the all-in one deployment case. In our docker images we change the default of GLAUTH_LDAPS_CERT but didn't change the new value...

Aktually I don't know if we futhermore should introduce a secondary ENV var like:

diff --git a/storage/pkg/flagset/ldap.go b/storage/pkg/flagset/ldap.go
index e550a60d7..a021f0395 100644
--- a/storage/pkg/flagset/ldap.go
+++ b/storage/pkg/flagset/ldap.go
@@ -30,7 +30,7 @@ func LDAPWithConfig(cfg *config.Config) []cli.Flag {
                        Name:        "ldap-cacert",
                        Value:       flags.OverrideDefaultString(cfg.Reva.LDAP.CACert, path.Join(pkgos.MustUserConfigDir("ocis", "ldap"), "ldap.crt")),
                        Usage:       "Path to a trusted Certificate file (in PEM format) for the LDAP Connection",
-                       EnvVars:     []string{"STORAGE_LDAP_CACERT"},
+                       EnvVars:     []string{"STORAGE_LDAP_CACERT", "GLAUTH_LDAPS_CERT"},
                        Destination: &cfg.Reva.LDAP.CACert,
                },
                &cli.BoolFlag{

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ownclouders]

💥 Acceptance tests Core-API-Tests-ocis-storage-2 failed. The build is cancelled...

[rhafer]

Aktually I don't know if we futhermore should introduce a secondary ENV var like

[...]

Hm, that could work. I am somewhat undecided on that. It seems a bit unclean. But that is true for the hardocded default (pkgos.MustUserConfigDir("ocis", "ldap"), "ldap.crt")) for STORAGE_LDAP_CACERT as well. OTOH it makes deployments simpler.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information