add public share auth middleware #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
force-pushed
the
public-share-auth-middleware
branch
from
4dac4ef to
1b4ae06
Compare
C0rby
force-pushed
the
public-share-auth-middleware
branch
from
1b4ae06 to
86a460c
Compare
wkloucek
force-pushed
the
public-share-auth-middleware
branch
from
86a460c to
73f8967
Compare
added 2 commits
October 15, 2021 16:48
The x-access-token for public shares is scoped for only the share. That means create home would fail because the token is not valid.
C0rby
force-pushed
the
public-share-auth-middleware
branch
from
73f8967 to
c74e125
Compare
C0rby
force-pushed
the
public-share-auth-middleware
branch
from
c74e125 to
f5aabe1
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new middleware which authenticates public share requests. I.e. it gets the x-access-token by authenticating via the share token and optionally the share password.
To test this you need to use this patched reva version: https://github.com/C0rby/reva/tree/public-share-app-auth
Related Issue
Motivation and Context
Some APIs like the appprovider need an authenticated context to be able to load files from the storage. With this middleware the appprovider doesn't need to learn about public links and instead can offer one way to open files in apps.
How Has This Been Tested?
Types of changes
Checklist: