Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update reva to v1.12 #2423

Merged
merged 1 commit into from
Aug 24, 2021
Merged

update reva to v1.12 #2423

merged 1 commit into from
Aug 24, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Aug 20, 2021 •
edited
Loading

Updating reva for the upcoming release.
This is just a preparation, later today when reva has been tagged I'll update to the tagged version.

  • Change reva version to 1.12

@C0rby C0rby mentioned this pull request Aug 20, 2021
Closed
20 tasks
@ownclouders
Copy link
Contributor

💥 Acceptance tests Core-API-Tests-ocis-storage-8 failed. The build is cancelled...

@phil-davis
Copy link
Contributor

We got the core commit id for tests up-to-date in PR #2419
Rebasing this will be a good idea, or you might get out-dated expected-failures diffs.

@C0rby C0rby force-pushed the update-reva branch 2 times, most recently from 0f83e07 to 0a9f0bb Compare August 24, 2021 08:01
@C0rby C0rby changed the title update reva to v1.11.1-0.20210820081958-18b230c6df87 update reva to v1.12 Aug 24, 2021
@C0rby C0rby marked this pull request as ready for review August 24, 2021 08:02
@phil-davis
Copy link
Contributor

https://github.com/owncloud/ocis/tree/update-reva says it is 6 commits behind master. That is before web 4.1.0 was merged to master. It might be worth rebasing this so it runs with the latest web.

@C0rby C0rby requested review from refs and pascalwengerter August 24, 2021 08:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pascalwengerter
pascalwengerter approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changelog/unreleased/update-reva.md Show resolved Hide resolved
kulmann
kulmann approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@C0rby C0rby merged commit 3358153 into master Aug 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-reva branch August 24, 2021 09:11
ownclouders pushed a commit that referenced this pull request Aug 24, 2021
commit 3358153
147355e 
Merge: 291b5fa f902633
Author: David Christofas <[email protected]>
Date:   Tue Aug 24 05:11:11 2021 -0400

    Merge pull request #2423 from owncloud/update-reva

    update reva to v1.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann kulmann approved these changes

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@C0rby @ownclouders @phil-davis @kulmann @pascalwengerter