Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt OpenTelemetry #2372

Merged
merged 37 commits into from
Aug 18, 2021
Merged

Adopt OpenTelemetry #2372

merged 37 commits into from
Aug 18, 2021

Conversation

refs
Copy link
Member

@refs refs commented Aug 9, 2021 •
edited
Loading

OpenTelemetry is the merger of OpenCensus and OpenTracing, a Sandbox project of the CNCF, and upgrades from opencensus and opentracing are encouraged as support for them will drop.

Reva counterpart: cs3org/reva#1984

refs added 19 commits August 6, 2021 11:29
@refs
remove tracing from ocis/ocis
0e59776
@refs
add otel dependencies
6b1c8d1
@refs
run go mod tidy
8e5ef03
@refs
add OCIS_TRACING_* flags to all extensions
93f1338
@refs
enable traces in proxy
9f50776
@refs
add tracing middleware to proxy middleware chain
9f96321
@refs
add tracing middleware to ocs middleware chain
feed3e5
@refs
propagate trace from ocs to proxy
8301a7e
@refs
Merge branch 'master' into remake-traces
33b1524
@refs
add test spans
2bdd07e
@refs
remove redundant middleware
43a97f6
@refs
replace go.opencensus.io with opentelemetry
0eb403d
@refs
Merge branch 'master' into remake-traces
500a77f
@refs
replace go.opencensus.io with opentelemetry in idp
45f29fd
@refs
replace go.opencensus.io with opentelemetry in store
f5c3b49
@refs
replace go.opencensus.io with opentelemetry in thumbnails
2a60b6b
@refs
prevent having a nil traceprovider
fe530e9
@refs
replace opencensus everywhere
ac087d0
@refs
fix middleware chain
4a81795
@update-docs
Copy link

update-docs bot commented Aug 9, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs refs self-assigned this Aug 9, 2021
@refs refs changed the title [WIP] Adopt OpenTelemetry Adopt OpenTelemetry Aug 17, 2021
@refs refs marked this pull request as ready for review August 17, 2021 12:05
@refs refs requested review from butonic and C0rby and removed request for kulmann and pascalwengerter August 17, 2021 12:05
C0rby
C0rby approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small remark.

proxy/pkg/middleware/accesslog.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

27.8% 27.8% Coverage
14.9% 14.9% Duplication

@refs refs merged commit 50c37d9 into master Aug 18, 2021
@refs refs deleted the remake-traces branch August 18, 2021 14:12
ownclouders pushed a commit that referenced this pull request Aug 18, 2021
@refs
commit 50c37d9
8f34931 
Merge: aeebf76 46f0d6f
Author: Alex Unger <[email protected]>
Date:   Wed Aug 18 16:12:54 2021 +0200

    Merge pull request #2372 from owncloud/remake-traces
@wkloucek wkloucek mentioned this pull request Aug 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees

@refs refs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refs @C0rby