Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Update web to 3.4.0 #2276

Merged
merged 3 commits into from
Jul 10, 2021
Merged

[full-ci] Update web to 3.4.0 #2276

merged 3 commits into from
Jul 10, 2021

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 8, 2021 •
edited
Loading

Update web to 3.4.0

@kulmann kulmann requested a review from pascalwengerter as a code owner July 8, 2021 22:19
@kulmann kulmann self-assigned this Jul 8, 2021
@kulmann kulmann marked this pull request as draft July 8, 2021 22:23
@kulmann kulmann changed the title Update web to 3.4.0-rc1 [full-ci] Update web to 3.4.0 Jul 9, 2021
@kulmann kulmann marked this pull request as ready for review July 9, 2021 11:11
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

phil-davis
phil-davis approved these changes Jul 10, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there are a couple of non-essential "moves" in the expected-failures file, but they don't hurt anything.

tests/acceptance/expected-failures-webUI-on-OCIS-storage.md Show resolved Hide resolved
tests/acceptance/expected-failures-webUI-on-OCIS-storage.md Show resolved Hide resolved
tests/acceptance/expected-failures-webUI-on-OCIS-storage.md Show resolved Hide resolved
@kulmann
Copy link
Member Author

kulmann commented Jul 10, 2021

I only copied the expected failures file from the web repo. There were three unexpected passes with that (see latest commit). I hope that's fine.

@phil-davis
Copy link
Contributor

I only copied the expected failures file from the web repo. There were three unexpected passes with that (see latest commit). I hope that's fine.

Feel free to merge. We will sort out any minor shuffling of lines in expected-failures when we do regular commit-id updates.

@kulmann kulmann merged commit 5341906 into master Jul 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-web-3.4.0 branch July 10, 2021 07:25
ownclouders pushed a commit that referenced this pull request Jul 10, 2021
@kulmann
commit 5341906
74074d8 
Merge: caaf7e6 96738d2
Author: Benedikt Kulmann <[email protected]>
Date:   Sat Jul 10 09:25:30 2021 +0200

    Merge pull request #2276 from owncloud/update-web-3.4.0
@micbar micbar mentioned this pull request Jul 13, 2021
Closed
21 tasks
This was referenced Jul 13, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @phil-davis