Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] update core commitid for tests #2234

Merged
merged 1 commit into from
Jul 2, 2021
Merged

[Tests-Only] update core commitid for tests #2234

merged 1 commit into from
Jul 2, 2021

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jun 30, 2021 •
edited
Loading

Description

Skip tests for async file operations as they wont be implemented in ocis
#1790 (comment)

Skip tests for default blacklisted filename .htaccess for ocis

add new env variable UPLOAD_DELETE_WAIT_TIME so that the tests dont wait between uploads and deletes for ocis storage driver.

Related Issue

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@dpakach dpakach force-pushed the skip-async-tests branch from accf880 to b79c2a1 Compare June 30, 2021 11:01
@dpakach dpakach marked this pull request as draft July 1, 2021 04:54
@dpakach dpakach changed the title [Tests-Only] skip tests for async file operations [Tests-Only] update core commitid for tests Jul 1, 2021
@dpakach dpakach force-pushed the skip-async-tests branch 3 times, most recently from 0459909 to bec58f9 Compare July 2, 2021 05:04
@dpakach dpakach force-pushed the skip-async-tests branch from bec58f9 to 3ffd0a1 Compare July 2, 2021 05:31
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dpakach dpakach marked this pull request as ready for review July 2, 2021 06:31
@dpakach dpakach requested review from jasson99 and saw-jan July 2, 2021 06:31
@dpakach dpakach self-assigned this Jul 2, 2021
@dpakach dpakach added QA:team Status:Needs-Review Needs review from a maintainer labels Jul 2, 2021
phil-davis
phil-davis approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out, and doing the changes for UPLOAD_DELETE_WAIT_TIME
It is good that the API tests are passing without any 1-second waits with the OCIS storage driver.

@phil-davis phil-davis merged commit 296b41d into master Jul 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the skip-async-tests branch July 2, 2021 08:02
ownclouders pushed a commit that referenced this pull request Jul 2, 2021
@phil-davis
commit 296b41d
723dc69 
Merge: 1cc0286 3ffd0a1
Author: Phil Davis <[email protected]>
Date:   Fri Jul 2 13:47:02 2021 +0545

    Merge pull request #2234 from owncloud/skip-async-tests

    [Tests-Only] update core commitid for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar

@wkloucek wkloucek Awaiting requested review from wkloucek

@jasson99 jasson99 Awaiting requested review from jasson99

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@dpakach dpakach

Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpakach @phil-davis