Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] remove outdated issues from expected failures file #2158

Merged
merged 2 commits into from
Jun 16, 2021
Merged

[Tests-Only] remove outdated issues from expected failures file #2158

merged 2 commits into from
Jun 16, 2021

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jun 10, 2021 •
edited
Loading

Description

[Tests-Only] remove outdated issues from expected failures file #2158

Related Issue

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jun 10, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dpakach dpakach force-pushed the update-exp-failure-file-dpakach branch 8 times, most recently from 690962a to ee8da5f Compare June 15, 2021 03:55
@dpakach dpakach changed the title Update exp failure file dpakach [Tests-Only] remove outdated issues from expected failures file Jun 15, 2021
@dpakach dpakach self-assigned this Jun 15, 2021
@dpakach dpakach force-pushed the update-exp-failure-file-dpakach branch from ee8da5f to eec7c0b Compare June 15, 2021 03:58
@dpakach dpakach marked this pull request as ready for review June 15, 2021 03:59
@dpakach dpakach force-pushed the update-exp-failure-file-dpakach branch from eec7c0b to ddf9c87 Compare June 15, 2021 07:16
@jasson99 jasson99 mentioned this pull request Jun 15, 2021
Merged
9 tasks
@dpakach dpakach force-pushed the update-exp-failure-file-dpakach branch from ddf9c87 to 177ca6f Compare June 15, 2021 10:31
kiranparajuli589
kiranparajuli589 reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

Talank
Talank reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpakach dpakach force-pushed the update-exp-failure-file-dpakach branch from 177ca6f to 8389322 Compare June 16, 2021 04:25
@dpakach dpakach requested a review from jasson99 June 16, 2021 04:35
@dpakach dpakach force-pushed the update-exp-failure-file-dpakach branch from 8389322 to c03428e Compare June 16, 2021 05:36
@dpakach dpakach force-pushed the update-exp-failure-file-dpakach branch from 173d555 to 63ce4ab Compare June 16, 2021 07:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 36971ea into master Jun 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-exp-failure-file-dpakach branch June 16, 2021 11:31
ownclouders pushed a commit that referenced this pull request Jun 16, 2021
@phil-davis
commit 36971ea
0df566a 
Merge: bbc01b3 63ce4ab
Author: Phil Davis <[email protected]>
Date:   Wed Jun 16 17:16:43 2021 +0545

    Merge pull request #2158 from owncloud/update-exp-failure-file-dpakach

    [Tests-Only] remove outdated issues from expected failures file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Talank Talank Talank left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@jasson99 jasson99 jasson99 approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@dpakach dpakach

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dpakach @phil-davis @Talank @kiranparajuli589 @jasson99