Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly configure the graph-explorer openid connect client #2118

Merged
merged 1 commit into from
Jun 10, 2021
Merged

properly configure the graph-explorer openid connect client #2118

merged 1 commit into from
Jun 10, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jun 4, 2021

The client registration in the identifier-registration.yaml for the grap-explorer didn't contain redirect_uris nor origins. Both were added to prevent exploitation.

@C0rby C0rby requested review from michaelstingl, IljaN and butonic June 4, 2021 13:26
@C0rby C0rby self-assigned this Jun 4, 2021
@C0rby C0rby requested a review from refs June 9, 2021 12:32
@C0rby C0rby force-pushed the graph-explorer-client-registration branch from ecb2359 to 68079b7 Compare June 10, 2021 11:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@C0rby C0rby merged commit 7062b43 into master Jun 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the graph-explorer-client-registration branch June 10, 2021 11:51
ownclouders pushed a commit that referenced this pull request Jun 10, 2021
commit 7062b43
7201da7 
Merge: fd8b3d2 68079b7
Author: David Christofas <[email protected]>
Date:   Thu Jun 10 13:51:44 2021 +0200

    Merge pull request #2118 from owncloud/graph-explorer-client-registration

    properly configure the graph-explorer openid connect client
@renovate renovate bot mentioned this pull request Jun 28, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jul 6, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refs refs refs approved these changes

@michaelstingl michaelstingl Awaiting requested review from michaelstingl

@IljaN IljaN Awaiting requested review from IljaN

@butonic butonic Awaiting requested review from butonic

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C0rby @refs