Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starlark format linting #2023

Merged
merged 4 commits into from
May 6, 2021
Merged

starlark format linting #2023

merged 4 commits into from
May 6, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 6, 2021 •
edited
Loading

Description

Add pipeline to ensure that .drone.star is properly formatted.
Format the .drone.start in order to pass the new CI step.

@update-docs
Copy link

update-docs bot commented May 6, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

phil-davis
phil-davis approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully it just re-formatted .drone.star without injecting or taking away anything :)

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/4932
unhandled index operation function[string]

That is not a very helpful message - no clue about the line number...

My guess is that there was some single-quoted string that had double-quotes literally in the string. Now the string are surrounded by double-quotes, and literal double-quotes will need to be escaped. Or some other random thing!

@wkloucek
Copy link
Contributor Author

wkloucek commented May 6, 2021

Hopefully it just re-formatted .drone.star without injecting or taking away anything :)

My changes are in these commits:

https://drone.owncloud.com/owncloud/ocis/4932
unhandled index operation function[string]

That is not a very helpful message - no clue about the line number...

My guess is that there was some single-quoted string that had double-quotes literally in the string. Now the string are surrounded by double-quotes, and literal double-quotes will need to be escaped. Or some other random thing!

and this commit was to fix the invalid starlark, causing the cryptic drone error:
ba58cf8

phil-davis
phil-davis approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. CI got a "random" error in one of the UI test pipelines. I cancelled and restarted it.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit d3f6298 into master May 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the starlark_format_linting branch May 6, 2021 12:35
ownclouders pushed a commit that referenced this pull request May 6, 2021
@wkloucek
commit d3f6298
a40cc5f 
Merge: 74e4788 ba58cf8
Author: Willy Kloucek <[email protected]>
Date:   Thu May 6 14:35:31 2021 +0200

    Merge pull request #2023 from owncloud/starlark_format_linting

    starlark format linting
This was referenced Jul 28, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis phil-davis approved these changes

@micbar micbar Awaiting requested review from micbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @phil-davis @individual-it