Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reva to v1.7.1-0.20210430154404-69bd21f2cc97 #2010

Merged
merged 2 commits into from
May 4, 2021
Merged

Update reva to v1.7.1-0.20210430154404-69bd21f2cc97 #2010

merged 2 commits into from
May 4, 2021

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented May 4, 2021

Description

This PR updates reva to current master at 69bd21f2cc97 (v1.7.1-0.20210430154404-69bd21f2cc97)

How Has This Been Tested?

  • drone

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested review from C0rby and wkloucek May 4, 2021 10:27
@kulmann kulmann requested a review from LukasHirt as a code owner May 4, 2021 10:27
@kulmann kulmann self-assigned this May 4, 2021
@kulmann kulmann force-pushed the update-reva-to-v1.7.1-0.20210430154404-69bd21f2cc97 branch from 87f9f26 to b833706 Compare May 4, 2021 10:41
wkloucek
wkloucek approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulmann kulmann force-pushed the update-reva-to-v1.7.1-0.20210430154404-69bd21f2cc97 branch from b833706 to 5653087 Compare May 4, 2021 13:20
@phil-davis
Copy link
Contributor

phil-davis commented May 4, 2021 •
edited
Loading

There are some "unexpected passed" scenarios that need to be removed from the expected-failures files. That is a great thing, just needs to be done. I can easily do it, if you like, @kulmann

@phil-davis
Copy link
Contributor

I can easily do it, if you like

done

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit 6336803 into master May 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-reva-to-v1.7.1-0.20210430154404-69bd21f2cc97 branch May 4, 2021 14:50
@kulmann
Copy link
Contributor Author

kulmann commented May 4, 2021

Thank you for taking care @phil-davis

ownclouders pushed a commit that referenced this pull request May 4, 2021
@kulmann
commit 6336803
22759b4 
Merge: f9afcbc ee73e44
Author: Benedikt Kulmann <[email protected]>
Date:   Tue May 4 16:50:50 2021 +0200

    Merge pull request #2010 from owncloud/update-reva-to-v1.7.1-0.20210430154404-69bd21f2cc97

    Update reva to v1.7.1-0.20210430154404-69bd21f2cc97
@renovate renovate bot mentioned this pull request Jun 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@C0rby C0rby C0rby approved these changes

@wkloucek wkloucek wkloucek approved these changes

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kulmann @phil-davis @C0rby @wkloucek