Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use oc-select in settings #1979

Merged
merged 4 commits into from
Apr 28, 2021
Merged

Use oc-select in settings #1979

merged 4 commits into from
Apr 28, 2021

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 28, 2021 •
edited
Loading

Description

Replace oc-drop with oc select in settings

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@AlexAndBear AlexAndBear requested a review from kulmann April 28, 2021 12:25
@AlexAndBear AlexAndBear changed the title refactor settings-single-choiche Use oc-select in settings Apr 28, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review April 28, 2021 13:30
@owncloud owncloud deleted a comment from update-docs bot Apr 28, 2021
@AlexAndBear AlexAndBear force-pushed the ocis-settings-use-oc-select branch from 576530d to 778aa25 Compare April 28, 2021 14:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@AlexAndBear AlexAndBear merged commit 7405812 into master Apr 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the ocis-settings-use-oc-select branch April 28, 2021 15:23
ownclouders pushed a commit that referenced this pull request Apr 28, 2021
commit 7405812
2068085 
Merge: 7d96824 778aa25
Author: Jan Ackermann <[email protected]>
Date:   Wed Apr 28 17:23:51 2021 +0200

    Merge pull request #1979 from owncloud/ocis-settings-use-oc-select

    Use oc-select in settings
@renovate renovate bot mentioned this pull request Jun 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAndBear @pascalwengerter