-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of PR#755 #1962
Rework of PR#755 #1962
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@@ -358,6 +367,100 @@ func (o Ocs) DeleteUser(w http.ResponseWriter, r *http.Request) { | |||
return | |||
} | |||
|
|||
if o.config.RevaAddress != "" && o.config.StorageUsersDriver != "owncloud" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this not work for the owncloud
driver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@butonic https://github.com/cs3org/reva/blob/master/pkg/storage/fs/owncloud/owncloud.go#L1146-L1152
// If home is enabled, the relative home is always the empty string
func (fs *ocfs) GetHome(ctx context.Context) (string, error) {
if !fs.c.EnableHome {
return "", errtypes.NotSupported("ocfs: get home not supported")
}
return "", nil
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logic probably should be more generic, but this at least makes the only consumer (CI) happy
Co-authored-by: Jörn Friedrich Dreyer <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Use the CS3 API and Reva to deprovision users completely.
Two new environment variables introduced:
OCS_IDM_ADDRESS
is also an alias forOCIS_URL
; allows the OCS service to mint jwt tokens for the authenticated user that will be read by the reva authentication middleware.OCS_STORAGE_USERS_DRIVER
determines how a user is deprovisioned. This kind of behavior is needed since every storage driver deals with deleting differently.This is being tested with:
TODO: