Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unique proto package names #1875

Merged
merged 2 commits into from
Mar 31, 2021
Merged

unique proto package names #1875

merged 2 commits into from
Mar 31, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Mar 30, 2021 •
edited
Loading

Description

This PR introduces unique package and go_package names in our Protobuf definitions.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek mentioned this pull request Mar 30, 2021
Closed
@wkloucek wkloucek linked an issue Mar 30, 2021 that may be closed by this pull request
Fix package name for proto files #1826
Closed
@wkloucek wkloucek changed the title fix proto package names unique proto package names Mar 31, 2021
@wkloucek wkloucek marked this pull request as ready for review March 31, 2021 06:03
@wkloucek wkloucek requested review from butonic, C0rby and refs March 31, 2021 06:03
refs
refs approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@refs refs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 Thanks! @wkloucek do we need to run protoc with this changes? Or will they result in no change at all? :)

@wkloucek
Copy link
Contributor Author

Thanks! @wkloucek do we need to run protoc with this changes? Or will they result in no change at all? :)

make generate doesn't produce any changes because the makefile is fucked up 👎 I will fix it and then merge it

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 3f37ddb into master Mar 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_proto branch March 31, 2021 10:56
ownclouders pushed a commit that referenced this pull request Mar 31, 2021
@wkloucek
commit 3f37ddb
ef718a5 
Merge: 0dadf6f 9bc0cb4
Author: Willy Kloucek <[email protected]>
Date:   Wed Mar 31 12:56:16 2021 +0200

    Merge pull request #1875 from owncloud/fix_proto

    unique proto package names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refs refs refs approved these changes

@butonic butonic Awaiting requested review from butonic

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix package name for proto files
2 participants
@wkloucek @refs