Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ocis-graph #1594

Merged
merged 12 commits into from
Feb 16, 2021
Merged

Add ocis-graph #1594

merged 12 commits into from
Feb 16, 2021

Conversation

refs
Copy link
Member

@refs refs commented Feb 4, 2021

git-subtree-dir: ocis-graph
git-subtree-mainline: 8146241
git-subtree-split: f1efadd

@refs
Add 'ocis-graph/' from commit 'f1efaddc27c74c9de4509cd864fc673ffdf52e19'
c981f51 
git-subtree-dir: ocis-graph
git-subtree-mainline: 8146241
git-subtree-split: f1efadd
@refs refs self-assigned this Feb 4, 2021
wkloucek
wkloucek approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkloucek
Copy link
Contributor

wkloucek commented Feb 5, 2021

@refs CI should be green soon

@kulmann
Copy link
Contributor

kulmann commented Feb 8, 2021

How do we handle changes in directory layout? I know that this PR was just about pulling over the repo, but e.g. docs live in a root level folder in the monorepo. I'm in favor of aligning with the monorepo structure before we merge this PR, i.e. bring the docs to the right place already with this PR. I'd be happy to do it, just didn't want to commit to your PR without asking first. ;-)

wkloucek
wkloucek requested changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation should be moved to github.com/owncloud/ocis/docs before merging as @kulmann stated.

kulmann and others added 4 commits February 15, 2021 10:24
@kulmann
Merge remote-tracking branch 'origin/master' into ocis-1643-migrate-o…
6d7e9c8 
…cis-graph
@kulmann
Move docs to top level folder
3f36228
@kulmann
Add graph and graph-explorer pipelines to drone config
7af5b82
fix makefile
8395d55 
The makefile was missing the assets step before generate. Re-added the assets step which downloads the graph-explorer lib
@C0rby
Copy link
Contributor

C0rby commented Feb 15, 2021

The assets step was removed. Was that intentional?

@C0rby
Copy link
Contributor

C0rby commented Feb 15, 2021 •
edited
Loading

Ugh...seems like we're playing a new round of randomly failing tests again...
https://drone.owncloud.com/owncloud/ocis/3433
https://drone.owncloud.com/owncloud/ocis/3437
It's always different ones...

Maybe the third restart will work.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic requested a review from wkloucek February 16, 2021 08:13
wkloucek
wkloucek approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will also go over it in #1580

@C0rby C0rby merged commit 0d3d0be into master Feb 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the ocis-1643-migrate-ocis-graph branch February 16, 2021 09:43
ownclouders pushed a commit that referenced this pull request Feb 16, 2021
@C0rby
commit 0d3d0be
e3e3014 
Merge: 8026bcb d1183fb
Author: David Christofas <[email protected]>
Date:   Tue Feb 16 10:43:43 2021 +0100

    Merge pull request #1594 from owncloud/ocis-1643-migrate-ocis-graph

    Add ocis-graph
@micbar micbar mentioned this pull request Feb 17, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

Assignees

@refs refs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@refs @wkloucek @kulmann @C0rby