Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add expose to docker images #1366

Merged
merged 1 commit into from
Jan 21, 2021
Merged

add expose to docker images #1366

merged 1 commit into from
Jan 21, 2021

Conversation

wkloucek
Copy link
Contributor

Description

This PR adds port exposure information to our released docker images. Expose see: https://docs.docker.com/engine/reference/builder/#expose

Related Issue

Motivation and Context

This adds information only. But for the user it is nice to see which ports of a docker container offer services.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested a review from xoxys January 20, 2021 15:36
@xoxys
Copy link
Contributor

xoxys commented Jan 20, 2021

As tcp is the default and to keep it (somehow) in sync with https://github.com/owncloud-docker/ should we strip /tcp? What do you think?

@wkloucek
Copy link
Contributor Author

As tcp is the default and to keep it (somehow) in sync with https://github.com/owncloud-docker/ should we strip /tcp? What do you think?

I like it more explicitly but if you prefer to remove it I am fine with it too.

@xoxys
Copy link
Contributor

xoxys commented Jan 21, 2021

No, fine for me 🙂

@wkloucek wkloucek force-pushed the add_expose_docker_image branch from 056772c to b749ffe Compare January 21, 2021 07:29
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/2776/23/7

runsh: Total unexpected failed scenarios throughout the test run:
apiProvisioning-v1/disableUser.feature:179

"random" test fail! I will restart drone.

@phil-davis phil-davis force-pushed the add_expose_docker_image branch from d0c90d1 to 1a18a49 Compare January 21, 2021 13:38
@phil-davis
Copy link
Contributor

I merged another PR to OCIS. So I rebased here again. Maybe you will win the race this time.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 6329d1b into master Jan 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the add_expose_docker_image branch January 21, 2021 14:37
ownclouders pushed a commit that referenced this pull request Jan 21, 2021
@wkloucek
commit 6329d1b
1dc472a 
Merge: 27d1783 1a18a49
Author: Willy Kloucek <[email protected]>
Date:   Thu Jan 21 15:37:52 2021 +0100

    Merge pull request #1366 from owncloud/add_expose_docker_image

    add expose to docker images
@kulmann kulmann mentioned this pull request Jan 22, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoxys xoxys xoxys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @xoxys @phil-davis