Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Convert expected failure file to markdown #1348

Merged
merged 5 commits into from
Jan 21, 2021
Merged

[Tests-Only] Convert expected failure file to markdown #1348

merged 5 commits into from
Jan 21, 2021

Conversation

haribhandari07
Copy link
Contributor

@haribhandari07 haribhandari07 commented Jan 18, 2021 •
edited
Loading

Description

This PR converts the remaining expected failure text files to markdown.

Related Issue

Motivation and Context

How Has This Been Tested?

  • Manual
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis
Copy link
Contributor

Codacy passed - so it is happy with the format of the .md files - that is a great start.

Note: tomorrow there will be a core PR to adjust core run.sh, and changes here to .drone.star to use these .md files

@haribhandari07 haribhandari07 mentioned this pull request Jan 19, 2021
Merged
11 tasks
@haribhandari07 haribhandari07 marked this pull request as ready for review January 19, 2021 10:09
@haribhandari07 haribhandari07 self-assigned this Jan 19, 2021
phil-davis
phil-davis reviewed Jan 19, 2021
View reviewed changes
tests/acceptance/expected-failures-API-on-OCIS-storage.md Outdated Show resolved Hide resolved
tests/acceptance/expected-failures-API-on-OCIS-storage.md Outdated Show resolved Hide resolved
tests/acceptance/expected-failures-API-on-OCIS-storage.md
- [apiShareCreateSpecialToShares2/createShareWithDisabledUser.feature:21](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiShareCreateSpecialToShares2/createShareWithDisabledUser.feature#L21)
- [apiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature:51](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature#L51)
- [apiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature:52](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature#L52)
- [apiShareCreateSpecialToShares2/createShareWithInvalidPermissions.feature:70](https://github.com/owncloud/core/blob/master/tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of repeats of this heading. Put them all into 1 list.

tests/acceptance/expected-failures-API-on-OCIS-storage.md Outdated Show resolved Hide resolved
tests/acceptance/expected-failures-API-on-OCIS-storage.md Outdated Show resolved Hide resolved
tests/acceptance/expected-failures-API-on-OCIS-storage.md Outdated Show resolved Hide resolved
tests/acceptance/expected-failures-API-on-EOS-storage.md Outdated Show resolved Hide resolved
tests/acceptance/expected-failures-API-on-OWNCLOUD-storage.md Outdated Show resolved Hide resolved
tests/acceptance/expected-failures-API-on-OWNCLOUD-storage.md Outdated Show resolved Hide resolved
tests/acceptance/expected-failures-API-on-OWNCLOUD-storage.md Outdated Show resolved Hide resolved
@phil-davis
Copy link
Contributor

The actual expected-failure entries might also need to be adjusted a bit, because this PR bumps the commit id past some other core PRs that could change the expected-failures. But we will see that when we get a clean run of CI and it reports only a few differences in the failures.

@phil-davis phil-davis self-requested a review January 19, 2021 11:42
@haribhandari07 haribhandari07 force-pushed the convert-to-md branch 3 times, most recently from 0380fb1 to 807fff5 Compare January 20, 2021 03:11
@phil-davis
Copy link
Contributor

For the "web" tests, you will probably have to remove some scenarios from expected-failures because actually they pass (or do not exist). They accidentally got into expected-failures:
owncloud/web@d2d8609

@phil-davis
Copy link
Contributor

And I skipped these intermittent scenarios yesterday in core: https://drone.owncloud.com/owncloud/ocis/2737/35/7

runsh: Total unexpected passed scenarios throughout the test run:
apiWebdavEtagPropagation1/moveFileFolder.feature:41
apiWebdavEtagPropagation1/moveFileFolder.feature:42
apiWebdavEtagPropagation1/moveFileFolder.feature:61
apiWebdavEtagPropagation1/moveFileFolder.feature:62

So they need to be removed from expected-failures.

@phil-davis
Copy link
Contributor

The accountsUITests failed. That should be unrelated. :(
https://drone.owncloud.com/owncloud/ocis/2739/73/7

I will restart.

@phil-davis
Copy link
Contributor

I keep restarting drone CI - but it keeps getting fails in "accountsUITests" and sometimes in webUITrashbinDelete/trashbinDelete.feature:80

OCIS CI seems a bit "strange" today.

@phil-davis
Copy link
Contributor

I will rebase and force-push. Then see what happens to CI.

@phil-davis
Copy link
Contributor

CI is still failing for accounts UI tests https://drone.owncloud.com/owncloud/ocis/2748/73/7
I don't see anything in this PR that can effect those tests.
I made PR #1363 to get an independent check of CI.

@phil-davis phil-davis mentioned this pull request Jan 21, 2021
Merged
9 tasks
@phil-davis
Copy link
Contributor

@haribhandari07 I just merged PR #1368 - please rebase this again and maybe it will pass.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@haribhandari07 haribhandari07 merged commit e51223b into master Jan 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the convert-to-md branch January 21, 2021 05:53
ownclouders pushed a commit that referenced this pull request Jan 21, 2021
@haribhandari07
commit e51223b
8510813 
Merge: 1a857e4 c4d4e53
Author: Hari Bhandari <[email protected]>
Date:   Thu Jan 21 11:38:15 2021 +0545

    Merge pull request #1348 from owncloud/convert-to-md

    [Tests-Only] Convert expected failure file to markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees

@haribhandari07 haribhandari07

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make expected failures files more readable
2 participants
@haribhandari07 @phil-davis