Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] add tests to remove access of shared resource to federated user #10672

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[tests-only][full-ci] add tests to remove access of shared resource to federated user #10672

merged 1 commit into from
Dec 17, 2024

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Nov 27, 2024 •
edited
Loading

Description

This PR adds test to remove access of a shared resource to federated user.

Scenario Outline: local user removes access of federated user from a resource

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 mentioned this pull request Nov 27, 2024
Open
30 tasks
@prashant-gurung899 prashant-gurung899 self-assigned this Nov 27, 2024
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-delete-share branch 2 times, most recently from f9f042c to 7e37e5a Compare November 27, 2024 08:29
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review November 27, 2024 09:11
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-delete-share branch 4 times, most recently from e3266d0 to 7ba257a Compare November 28, 2024 08:47
@prashant-gurung899
Copy link
Contributor Author

prashant-gurung899 commented Nov 29, 2024 •
edited
Loading

This PR is on hold because of bug; #10689
So, moving it to blocked for now.

@prashant-gurung899
Copy link
Contributor Author

Moving it back to in progress from blocked

@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-delete-share branch 2 times, most recently from 9474779 to 208932e Compare December 11, 2024 06:15
saw-jan
saw-jan reviewed Dec 12, 2024
View reviewed changes
tests/acceptance/bootstrap/SharingNgContext.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/SharingNgContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/apiOcm/share.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiOcm/share.feature Outdated Show resolved Hide resolved
@prashant-gurung899 prashant-gurung899 mentioned this pull request Dec 16, 2024
Merged
9 tasks
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-delete-share branch 2 times, most recently from 2a822b6 to ad80e51 Compare December 16, 2024 06:29
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-delete-share branch 2 times, most recently from 118d261 to 32dd280 Compare December 17, 2024 04:56
amrita-shrestha
amrita-shrestha approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@prashant-gurung899 prashant-gurung899 merged commit 0832c9b into master Dec 17, 2024
4 checks passed
@prashant-gurung899 prashant-gurung899 deleted the tests-ocm-delete-share branch December 17, 2024 07:13
ownclouders pushed a commit that referenced this pull request Dec 17, 2024
@prashant-gurung899
Merge pull request #10672 from owncloud/tests-ocm-delete-share
0475c63 
[tests-only][full-ci] add tests to remove access of shared resource to federated user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@saw-jan saw-jan saw-jan approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@S-Panta S-Panta Awaiting requested review from S-Panta

@ishabaral ishabaral Awaiting requested review from ishabaral

@nabim777 nabim777 Awaiting requested review from nabim777

Assignees

@prashant-gurung899 prashant-gurung899

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prashant-gurung899 @saw-jan @amrita-shrestha @S-Panta @PrajwolAmatya