Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] add tests to check file uploads with same mtime and different content #10597

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Nov 19, 2024

Description

Added scenarios:

# normal and TUS upload
Scenario Outline: upload a file with the same mtime and same content multiple times (atleast 3 times)
Scenario Outline: upload a file with the same mtime and different content multiple times (atleast 3 times)

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: 🙌 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Nov 19, 2024
@saw-jan saw-jan force-pushed the tests/upload-same-mtime-file branch from 20d659c to b702f40 Compare November 19, 2024 06:45
@saw-jan saw-jan marked this pull request as ready for review November 19, 2024 06:45
Comment on lines 192 to 201
#### [Uploading with the same mtime and filename causes "internal server errors"](https://github.com/owncloud/ocis/issues/10496)

- [coreApiWebdavUpload/uploadFile.feature:415](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUpload/uploadFile.feature#L415)
- [coreApiWebdavUpload/uploadFile.feature:416](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiWebdavUpload/uploadFile.feature#L416)
Copy link
Member Author

@saw-jan saw-jan Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhafer If the bug #10496 will be fixed soon, I will remove these expected failure lines and wait for the fix. but if not I want to merge the PR with expected failure so that it can be used to check whether the bug is fixed or not in the fix PR.

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saw-jan saw-jan force-pushed the tests/upload-same-mtime-file branch 2 times, most recently from 36dc71c to 8249116 Compare November 20, 2024 05:39
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

due to cache multiple approval from my side, sry for that

@saw-jan saw-jan force-pushed the tests/upload-same-mtime-file branch from 8249116 to 7c1c9dd Compare November 21, 2024 04:19
@saw-jan saw-jan merged commit fbb319f into master Nov 21, 2024
2 checks passed
@saw-jan saw-jan deleted the tests/upload-same-mtime-file branch November 21, 2024 08:19
ownclouders pushed a commit that referenced this pull request Nov 21, 2024
[tests-only] add tests to check file uploads with same mtime and different content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants