Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] remove singlequotes around email address #1059

Merged
merged 2 commits into from
Dec 11, 2020
Merged

[docs-only] remove singlequotes around email address #1059

merged 2 commits into from
Dec 11, 2020

Conversation

jnweiger
Copy link
Contributor

Traefik complains that '[email protected]' has invalid characters. The quotes must not be there.

@jnweiger
remove singlequotes aound email address
cbbc930 
Traefik complains that `'[email protected]'` has invalid characters. The quotes must not be there.
@jnweiger jnweiger requested a review from wkloucek December 10, 2020 22:12
@update-docs
Copy link

update-docs bot commented Dec 10, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@phil-davis phil-davis changed the title remove singlequotes aound email address remove singlequotes around email address Dec 11, 2020
wkloucek
wkloucek approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed the singlequotes for the other examples.

If default email is not changed LetsEncrypt refuses because of: Contact emails @example.org are forbidden. This is the right behaviour instead of contact email \"'[email protected]'\" has invalid domain

@wkloucek wkloucek changed the title remove singlequotes around email address [docs-only] remove singlequotes around email address Dec 11, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit 78d2647 into master Dec 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the jnweiger-quoting-hell-in-yml branch December 11, 2020 08:30
ownclouders pushed a commit that referenced this pull request Dec 11, 2020
@wkloucek
commit 78d2647
2f1ea59 
Merge: 469b093 8f26922
Author: Willy Kloucek <[email protected]>
Date:   Fri Dec 11 09:30:33 2020 +0100

    Merge pull request #1059 from owncloud/jnweiger-quoting-hell-in-yml

    [docs-only] remove singlequotes around email address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnweiger @wkloucek