Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] refactor When steps and step defns while moving, copying and renaming files and folders #10558

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

anon-pradip
Copy link
Contributor

@anon-pradip anon-pradip commented Nov 13, 2024

Description

This pull request focuses on refactoring the When steps and their corresponding step definitions within the test suite. The changes are specifically related to the operations of moving, copying, and renaming files and folders.

  • Refactored the structure of (moves|copies) using file-id actions
  • Removed the renames using file-id action from the existing step definition and created a separate step definition specifically for renaming files.

Related Issue

  • Fixes <issue_link>

Motivation and Context

These changes are made to align the existing test codes with the PR #10409 ensuring consistency across the test suites, making it easier to understand, maintain, and extend in the future.

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@anon-pradip anon-pradip self-assigned this Nov 13, 2024
@anon-pradip anon-pradip force-pushed the test/refactor-steps-and-step-defns branch 6 times, most recently from 9f93e9a to 6d65ffb Compare November 19, 2024 05:56
@anon-pradip anon-pradip marked this pull request as ready for review November 19, 2024 06:56
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes

tests/acceptance/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
@anon-pradip anon-pradip force-pushed the test/refactor-steps-and-step-defns branch from 6d65ffb to 0baccb9 Compare November 19, 2024 11:33
@anon-pradip anon-pradip requested a review from saw-jan November 19, 2024 11:35
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saw-jan saw-jan merged commit 94931aa into master Nov 20, 2024
4 checks passed
@saw-jan saw-jan deleted the test/refactor-steps-and-step-defns branch November 20, 2024 03:55
ownclouders pushed a commit that referenced this pull request Nov 20, 2024
…defns

[tests-only][full-ci] refactor `When` steps and step defns while moving, copying and renaming files and folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants