Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use only the app name in order to name the lock #10447

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

jvillafanez
Copy link
Member

Description

Use only the app name for the lock. The lock owner should show OnlyOffice (the app name) instead of com.github.owncloud.collaboration.OnlyOffice (the lock name + app name)

Related Issue

owncloud/web#11008

Motivation and Context

How Has This Been Tested?

Manually checked with a propfind request. It shows just the app name

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

TODO

  • The LockName configuration option becomes unused with this change. We can remove the option.

@jvillafanez jvillafanez self-assigned this Oct 31, 2024
Copy link

update-docs bot commented Oct 31, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jvillafanez
Copy link
Member Author

We need to decide what to do with the LockName config option. Technically, we can remove the option (https://github.com/owncloud/ocis/blob/master/services/collaboration/pkg/config/app.go#L8), but maybe it's better to mark it as deprecated for now.

@kulmann
Copy link
Member

kulmann commented Oct 31, 2024

We need to decide what to do with the LockName config option. Technically, we can remove the option (https://github.com/owncloud/ocis/blob/master/services/collaboration/pkg/config/app.go#L8), but maybe it's better to mark it as deprecated for now.

cc @micbar @kobergj can you decide?

@micbar
Copy link
Contributor

micbar commented Nov 5, 2024

@jvillafanez @kobergj As this has not been released in ocis 5, i think we can safely drop that without deprecation.

@micbar
Copy link
Contributor

micbar commented Nov 5, 2024

please rebase

@jvillafanez jvillafanez force-pushed the collaboration_remove_lockname_config branch from 31196a7 to 8d80b5c Compare November 5, 2024 13:44
Copy link

sonarcloud bot commented Nov 5, 2024

@mmattel mmattel merged commit 21c584c into master Nov 5, 2024
4 checks passed
@mmattel mmattel deleted the collaboration_remove_lockname_config branch November 5, 2024 16:11
ownclouders pushed a commit that referenced this pull request Nov 5, 2024
…_config

feat: use only the app name in order to name the lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants