update events

[dragonchaser]

refs #9536

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[saw-jan]

build:https://drone.owncloud.com/owncloud/ocis/38989/58/10
web e2e test is failing because the activity message is not right:

[mmattel]

I was asked to take a look on Transifex. Two comments:

• The screenshot above shows the original language (English) from the source code and not something translated. This means, TX is not involved --> We have to look if there is a processing issue somewhere in the chain. Have a detailed look, the name of the space is called .space (dot space) and the filename is not resolved at all.
• I have taken a look into the German and also other translations and it looks fine, see screenshot below.

[saw-jan]

@mmattel the screenshot that I provided above is for web issue and maybe not related to translation.

The problem with translation is that with this PR the message has changed:
en: {user} added {resource} to {folder}
so I think we need change in other translations as well. e.g.:
de: {user} hat {resource} zu {folder} hinzugefügt

Note: {space} is changed to {folder}.

But I don't know how translation works and how to bring changes without merging the PR

[mmattel]

@saw-jan when looking into TX, there are no open translations for German for activitylog. So everything is up to date there. Note that the sync happens once a night. If there are string changes/additions here in the repo and they are urgently needed, you need to ask Phil for a manual sync, ping me for a translation and Phil needs to trigger sync afterwards again. Then you have the translation down here in this repo.

[saw-jan]

So that means if we merge this PR then the translation will be changed accordingly the next day or with manual sync?

[mmattel]

@saw-jan we need to make the tests working if one changes translatable text that is not merged. 🐔 🥚

@dragonchaser Q, for couriosity: Why is the target redefined from space to file and not added so we have messages for space and file?

[dragonchaser]

@saw-jan we need to make the tests working if one changes translatable text that is not merged. 🐔 🥚

@dragonchaser Q, for couriosity: Why is the target redefined from space to file and not added so we have messages for space and file?

#10049 (comment) miscommunication :)

[mmattel]

Attention #10072 is adding MessageResourceUpdated based on {space}... we need to take care 😱

UPDATE: #10072 has been adapted to be inline with this PR, merged.

I am afraid

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud