Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[graph/users] userType should be read-only for now. #9858

Closed
rhafer opened this issue Aug 20, 2024 · 1 comment · Fixed by #9867
Closed

[graph/users] userType should be read-only for now. #9858

rhafer opened this issue Aug 20, 2024 · 1 comment · Fixed by #9867
Assignees
@rhafer
Labels
Type:Bug

Comments

@rhafer
Copy link
Contributor

rhafer commented Aug 20, 2024

Describe the bug

It is currently possible to set the userType manually when creating a user via graph. We should prevent that for avoiding confusion.

  • Users with the userType Guest are supposed to created via the invite service (when that is fully ready).
  • Users with the userType Federated are supposed to be created via the ocm federation services
  • Users created via POST on the graph service should for now always have the type Member
@rhafer rhafer self-assigned this Aug 20, 2024
@rhafer rhafer moved this from Qualification to In progress in Infinite Scale Team Board Aug 20, 2024
@rhafer
Copy link
Contributor Author

rhafer commented Aug 20, 2024

cc @ScharfViktor

rhafer added a commit to rhafer/libre-graph-api that referenced this issue Aug 20, 2024
@rhafer
Mark user properties userType and memberOf as read-only
4203f7a 
We don't want 'userType' to be set on POST/PATCH requests for now.
Currenly users with a type different from 'Member' are created
either via ocm or via graph invite requests.
See: owncloud/ocis#9858 for details

Also 'memberOf' is a read-only relation in MS Graph.
@rhafer rhafer mentioned this issue Aug 20, 2024
Merged
rhafer added a commit to owncloud/libre-graph-api that referenced this issue Aug 20, 2024
@rhafer
Mark user properties userType and memberOf as read-only
3407270 
We don't want 'userType' to be set on POST/PATCH requests for now.
Currenly users with a type different from 'Member' are created
either via ocm or via graph invite requests.
See: owncloud/ocis#9858 for details

Also 'memberOf' is a read-only relation in MS Graph.
ownclouders pushed a commit to owncloud/libre-graph-api-php that referenced this issue Aug 20, 2024
@rhafer
Mark user properties userType and memberOf as read-only
38ec328 
We don't want 'userType' to be set on POST/PATCH requests for now.
Currenly users with a type different from 'Member' are created
either via ocm or via graph invite requests.
See: owncloud/ocis#9858 for details

Also 'memberOf' is a read-only relation in MS Graph.
ownclouders pushed a commit to owncloud/libre-graph-api-go that referenced this issue Aug 20, 2024
@rhafer
Mark user properties userType and memberOf as read-only
5fac809 
We don't want 'userType' to be set on POST/PATCH requests for now.
Currenly users with a type different from 'Member' are created
either via ocm or via graph invite requests.
See: owncloud/ocis#9858 for details

Also 'memberOf' is a read-only relation in MS Graph.
rhafer added a commit to rhafer/ocis that referenced this issue Aug 20, 2024
@rhafer
fix(graph): treat memberOf and userType as read-only attributes
99c0d02 
Fixes: owncloud#9858
@rhafer rhafer mentioned this issue Aug 20, 2024
Merged
rhafer added a commit to rhafer/ocis that referenced this issue Aug 20, 2024
@rhafer
fix(graph): treat memberOf and userType as read-only attributes
49b4147 
Fixes: owncloud#9858
rhafer added a commit to rhafer/ocis that referenced this issue Aug 20, 2024
@rhafer
fix(graph): treat memberOf and userType as read-only attributes
8476da2 
Fixes: owncloud#9858
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Type:Bug
Projects
Infinite Scale Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(graph): treat memberOf and userType as read-only attributes rhafer/ocis
1 participant
@rhafer