You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
basically we should kill OCIS_GATEWAY_GRPC_ADDR.
The four env vars are used partly redundant, partly conflicting, partly unneded: GATEWAY_GRPC_ADDR defines the bind address for the gateway service, a host and port or maybe a path when the GATEWAY_GRPC_PROTOCOL=unix for unix sockets. But it is never a service name. So:
OCIS_GATEWAY_GRPC_ADDR should not be read by the gateway service. Deprecate the env var,
OCIS_GATEWAY_GRPC_ADDR shoultd not be read by the storage-users service or overwritten with the more specific STORAGE_USERS_GATEWAY_GRPC_ADDR. The addr here is used by the trasbin commands to connect to the gateway. It can be an host:port address, a unix:/path/to/socket or a service name. currently defaults to ̀127.0.0.1:9142. It should be replaced with OCIS_REVA_GATEWAY;STORAGE_USERS_REVA_GATEWAY because it can be a service name.
WEB_GATEWAY_GRPC_ADDR should be OCIS_REVA_GATEWAY;WEB_REVA_GATEWAY because it can be a service name as well as an address. it is used by the web service to initiate logo changes
Now that being said, the yaml tag for OCIS_REVA_GATEWAY is inconsistent as well:
basically we should kill OCIS_GATEWAY_GRPC_ADDR.
The four env vars are used partly redundant, partly conflicting, partly unneded:
GATEWAY_GRPC_ADDR
defines the bind address for the gateway service, a host and port or maybe a path when theGATEWAY_GRPC_PROTOCOL=unix
for unix sockets. But it is never a service name. So:OCIS_GATEWAY_GRPC_ADDR
should not be read by the gateway service. Deprecate the env var,OCIS_GATEWAY_GRPC_ADDR
shoultd not be read by the storage-users service or overwritten with the more specificSTORAGE_USERS_GATEWAY_GRPC_ADDR
. The addr here is used by the trasbin commands to connect to the gateway. It can be an host:port address, a unix:/path/to/socket or a service name. currently defaults to ̀127.0.0.1:9142
. It should be replaced withOCIS_REVA_GATEWAY;STORAGE_USERS_REVA_GATEWAY
because it can be a service name.WEB_GATEWAY_GRPC_ADDR
should beOCIS_REVA_GATEWAY;WEB_REVA_GATEWAY
because it can be a service name as well as an address. it is used by the web service to initiate logo changesNow that being said, the yaml tag for OCIS_REVA_GATEWAY is inconsistent as well:
for yaml I think we have no override mechanic, right?
The text was updated successfully, but these errors were encountered: