Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable consolidation #8259

Open
dragonchaser opened this issue Jan 22, 2024 · 5 comments
Open

Environment variable consolidation #8259

dragonchaser opened this issue Jan 22, 2024 · 5 comments

Comments

@dragonchaser
Copy link
Contributor

At the moment we have tons of redundant environment variables that do not make sense IMHO.
For example we configure OCIS_LOG_LEVEL, OCIS_LOG_PRETTY, OCIS_LOG_COLOR, OCIS_LOG_FILE for every service.
It would be sufficient to define three of them (OCIS_LOG_PRETTY, OCIS_LOG_COLOR and OCIS_LOG_FILE) globally and just define a log level per service. This also applies to other variables and variable groups (e.g. Debug, RevaGateway etc.).

@dragonchaser
Copy link
Contributor Author

/cc @micbar && @mmattel

@butonic
Copy link
Member

butonic commented Feb 29, 2024

The reason for different prefixes is to allow changing the configuration of individual services when running in a single process.

We shoud phase out as many service specific variables as soon as possible. But they will need to stay in for backwards compatability.

I'm looking at the ServiceAccountsID env var which is another special case as every service should use a dedicated service account id. but then the settings service needs to know all accounts...

@dragonchaser
Copy link
Contributor Author

The reason for different prefixes is to allow changing the configuration of individual services when running in a single process.

We shoud phase out as many service specific variables as soon as possible. But they will need to stay in for backwards compatability.

Already possible, using our deprecation system, it would be awesome if we could get rid of that with 6.0. It would be desirable to have only one variable per annotation and move global vars to ocis-pkg

I'm looking at the ServiceAccountsID env var which is another special case as every service should use a dedicated service account id. but then the settings service needs to know all accounts...

👍

@butonic
Copy link
Member

butonic commented Feb 29, 2024

And we need to clarify how config parsing works in the docs https://owncloud.dev/ocis/config/

@fschade
Copy link
Contributor

fschade commented Jul 12, 2024

UP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Qualification
Development

No branches or pull requests

3 participants