Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push the requestID through the whole stack #7928

Closed
micbar opened this issue Dec 11, 2023 · 2 comments · Fixed by #8017
Closed

Push the requestID through the whole stack #7928

micbar opened this issue Dec 11, 2023 · 2 comments · Fixed by #8017
Assignees

Comments

@micbar
Copy link
Contributor

micbar commented Dec 11, 2023

The requestID is part of the context in the http layer.
In the past, it was pushed further through the stack and was also arriving in the grpc context.

As a consequence, all log lines in ocis were printing out the requestID.

This behavior has changed lately.

@butonic @kobergj

@micbar micbar converted this from a draft issue Dec 11, 2023
@micbar
Copy link
Contributor Author

micbar commented Dec 11, 2023

Good starting point:

  • Start to find out why the ocdav service is not passing the trace / request down to the storage provider

@butonic
Copy link
Member

butonic commented Dec 11, 2023

IMO we should log the requestID in the proxy only. tying logs together should be done by always enableing tracing so the traceid is not a zeroes by default. we could use a noop trace logger, but tracing itself should always be enabled to be able to aggregate logs.

obviously, passing the trace needs to work and might be affected by the same underlying bug of a context being disconnected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants