-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push the requestID through the whole stack #7928
Comments
Good starting point:
|
IMO we should log the requestID in the proxy only. tying logs together should be done by always enableing tracing so the traceid is not a zeroes by default. we could use a noop trace logger, but tracing itself should always be enabled to be able to aggregate logs. obviously, passing the trace needs to work and might be affected by the same underlying bug of a context being disconnected |
The requestID is part of the context in the http layer.
In the past, it was pushed further through the stack and was also arriving in the grpc context.
As a consequence, all log lines in ocis were printing out the requestID.
This behavior has changed lately.
@butonic @kobergj
The text was updated successfully, but these errors were encountered: