Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharee does not receive a mail notification when sharer unshares a resource #6636

Closed
nirajacharya2 opened this issue Jun 27, 2023 · 3 comments
Assignees
Labels

Comments

@nirajacharya2
Copy link
Contributor

nirajacharya2 commented Jun 27, 2023

Describe the bug

User does not get email notification when a resource is unshared.

Steps to reproduce

  1. Alice creates a resource textfile.txt
  2. share the resource to Brian using command curl -kv -X POST https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares -d 'shareType=0&path=/testfile.txt&permission=3&shareWith=brian' -u alice:123456
  3. Brian accepts the share
  4. Alice unshares the resource
curl -kv -X DELETE https://localhost:9200/ocs/v1.php/apps/files_sharing/api/v1/shares/<share-id> -u alice:123456

Expected behavior

Brian should receive a mail notification when resource is unshared by Alice

Actual behavior

Brian does not get any mail notification when the resource is unshared.

Setup

email server used: inbucket
Ocis : latest master

Additional context

Add any other context about the problem here.

@nirajacharya2 nirajacharya2 reopened this Jun 27, 2023
@nirajacharya2 nirajacharya2 changed the title mail about deleting access to share/space sharee does not recive a mail notification when sharer unshares a resource Jun 27, 2023
@nirajacharya2 nirajacharya2 changed the title sharee does not recive a mail notification when sharer unshares a resource sharee does not receive a mail notification when sharer unshares a resource Jun 29, 2023
@2403905 2403905 self-assigned this Jul 14, 2023
@2403905
Copy link
Contributor

2403905 commented Jul 14, 2023

There are only two share events that are triggered by email ShareCreated and ShareExpired and 3 for the Spaces

case events.ShareCreated:
s.handleShareCreated(e)
case events.ShareExpired:
s.handleShareExpired(e)

If we need more it could be the feature request

@phil-davis
Copy link
Contributor

What is the requirement?
"somebody" needs to define the requirement.

@SwikritiT
Copy link
Contributor

According to #6636 (comment) this is not an issue but a feature request. Closing this for now. If someone wants this feature it can be defined later like other notifications related unimplemented features #6649 (comment)

cc @ScharfViktor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants