-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With EOS storage backend, the new WebDAV API doesn't work on #409 #444
With EOS storage backend, the new WebDAV API doesn't work on #409 #444
Comments
ok this line gives a clue:
The internal path
It has to do with the way the internal paths are constructed using the user layout. I'll check the current defaults and the changes that are made with owncloud/ocis-reva#420 The two different configurations are necessary to make requests against thke two different endpoints construct the same internal path. The problem is that clients are sending the username / userid as part of the url for the new Short answer: try setting
|
should be fixed with 1c5e1ce |
@butonic. The new changes seems to have fixed the issue with the dav endpoints. As long as we use the uuid of the user that works fine. But some other issues still remain.
Server logs
Server Logs
|
This is the test result of running tests on EOS on toptests/acceptance/features/apiAuthOcs/ocsPOSTAuth.feature:52 of #409 Most of the failing scenarios are sharing related. Other few failing tests are due to mismatching status codes.
|
id lookup in the container works:
|
we need to implement getUserByClaim in revas ldap user driver: cs3org/reva#1088 |
now we also need to mint a token with uid and gid of the user set in the proxy: owncloud/ocis-proxy#89 |
setting ACLs is still using a blank uid / gid:
|
while testing with the default users einstein and marie works, the testsuite needs to be able to provision accounts using the ocs api: https://github.com/owncloud/ocis-ocs/issues/36 Then running the api tests from owncloud/core#37796 should work:
...
@dpakach hm, I have way more failing tests ... |
@butonic most of these tests fail in ocis even without the EOS storage. They probably already have issues for that. You can run with the following flag which will ignore the failures that are already failing in ocis.
Most of these tests fail because for me sharing is still not working.
Server Log:
|
running with
I get
|
comparing this with a run against beta8
|
diff -u beta8-results.txt beta9-results.txt
--- beta8-results.txt 2020-08-18 12:49:37.943345180 +0200
+++ beta9-results.txt 2020-08-18 12:50:01.510438729 +0200
@@ -1,73 +1,16 @@
-837 scenarios (16 passed, 821 failed)
-7761 steps (1686 passed, 821 failed, 5254 skipped)
-14m11.58s (26.17Mb)
+837 scenarios (216 passed, 621 failed)
+7761 steps (4684 passed, 621 failed, 2456 skipped)
+26m9.06s (22.40Mb)
[...]
1 scenario (1 skipped)
9 steps (9 skipped)
-0m0.17s (15.46Mb)
-runsh: Total 837 scenarios (16 passed, 821 failed)
+0m0.16s (15.46Mb)
+runsh: Total 837 scenarios (216 passed, 621 failed)
runsh: Exit code of main run: 1
runsh: Exit code after checking expected failures: 1
runsh: Total unexpected failed scenarios throughout the test run:
-apiMain/checksums.feature:13
-apiMain/checksums.feature:14
-apiMain/checksums.feature:226
-apiMain/checksums.feature:227
-apiAuth/webDavAuth.feature:8
-apiAuth/webDavAuth.feature:13
-apiAuthWebDav/webDavDELETEAuth.feature:15
-apiAuthWebDav/webDavDELETEAuth.feature:25
-apiAuthWebDav/webDavDELETEAuth.feature:45
-apiAuthWebDav/webDavDELETEAuth.feature:55
-apiAuthWebDav/webDavDELETEAuth.feature:67
-apiAuthWebDav/webDavLOCKAuth.feature:15
-apiAuthWebDav/webDavLOCKAuth.feature:27
-apiAuthWebDav/webDavLOCKAuth.feature:49
-apiAuthWebDav/webDavLOCKAuth.feature:59
-apiAuthWebDav/webDavLOCKAuth.feature:71
-apiAuthWebDav/webDavMKCOLAuth.feature:14
-apiAuthWebDav/webDavMKCOLAuth.feature:26
-apiAuthWebDav/webDavMKCOLAuth.feature:49
-apiAuthWebDav/webDavMKCOLAuth.feature:59
-apiAuthWebDav/webDavMKCOLAuth.feature:71
-apiAuthWebDav/webDavMOVEAuth.feature:14
-apiAuthWebDav/webDavMOVEAuth.feature:26
-apiAuthWebDav/webDavMOVEAuth.feature:45
-apiAuthWebDav/webDavMOVEAuth.feature:55
-apiAuthWebDav/webDavMOVEAuth.feature:67
-apiAuthWebDav/webDavPOSTAuth.feature:15
-apiAuthWebDav/webDavPOSTAuth.feature:27
-apiAuthWebDav/webDavPOSTAuth.feature:46
-apiAuthWebDav/webDavPOSTAuth.feature:56
-apiAuthWebDav/webDavPOSTAuth.feature:68
-apiAuthWebDav/webDavPROPFINDAuth.feature:14
-apiAuthWebDav/webDavPROPFINDAuth.feature:26
-apiAuthWebDav/webDavPROPFINDAuth.feature:45
-apiAuthWebDav/webDavPROPFINDAuth.feature:55
-apiAuthWebDav/webDavPROPFINDAuth.feature:67
-apiAuthWebDav/webDavPROPPATCHAuth.feature:15
-apiAuthWebDav/webDavPROPPATCHAuth.feature:27
-apiAuthWebDav/webDavPROPPATCHAuth.feature:46
-apiAuthWebDav/webDavPROPPATCHAuth.feature:56
-apiAuthWebDav/webDavPROPPATCHAuth.feature:68
-apiAuthWebDav/webDavPUTAuth.feature:15
-apiAuthWebDav/webDavPUTAuth.feature:27
-apiAuthWebDav/webDavPUTAuth.feature:49
-apiAuthWebDav/webDavPUTAuth.feature:59
-apiAuthWebDav/webDavPUTAuth.feature:71
-apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:22
-apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:23
-apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:24
-apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:25
-apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:26
-apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:27
-apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:28
-apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:29
-apiShareManagementBasic/createShare.feature:97
-apiShareManagementBasic/createShare.feature:120
-apiShareManagementBasic/createShare.feature:121
apiShareManagementBasic/deleteShare.feature:39
apiShareOperations/accessToShare.feature:20
apiShareOperations/accessToShare.feature:21
@@ -77,6 +20,8 @@
apiShareOperations/gettingShares.feature:55
apiSharePublicLink1/deletePublicLinkShare.feature:20
apiSharePublicLink1/deletePublicLinkShare.feature:21
+apiSharePublicLink1/deletePublicLinkShare.feature:53
+apiSharePublicLink1/deletePublicLinkShare.feature:54
apiSharePublicLink1/deletePublicLinkShare.feature:70
apiSharePublicLink1/deletePublicLinkShare.feature:71
apiSharePublicLink2/copyFromPublicLink.feature:9
@@ -123,19 +68,8 @@
apiSharePublicLink2/updatePublicLinkShare.feature:267
apiSharePublicLink2/updatePublicLinkShare.feature:511
apiSharePublicLink2/updatePublicLinkShare.feature:512
-apiWebdavMove1/moveFileAsync.feature:149
apiWebdavMove1/moveFileAsync.feature:214
apiWebdavMove1/moveFileAsync.feature:215
-apiWebdavMove1/moveFolder.feature:86
-apiWebdavMove1/moveFolder.feature:87
-apiWebdavMove1/moveFolder.feature:88
-apiWebdavMove1/moveFolder.feature:89
-apiWebdavMove1/moveFolder.feature:90
-apiWebdavMove1/moveFolder.feature:91
-apiWebdavMove1/moveFolder.feature:92
-apiWebdavMove1/moveFolder.feature:93
-apiWebdavMove1/moveFolder.feature:94
-apiWebdavMove1/moveFolder.feature:95
apiWebdavMove2/moveFile.feature:21
apiWebdavMove2/moveFile.feature:22
apiWebdavMove2/moveFile.feature:34
@@ -146,142 +80,10 @@
apiWebdavMove2/moveFile.feature:58
apiWebdavMove2/moveFile.feature:68
apiWebdavMove2/moveFile.feature:69
-apiWebdavMove2/moveFile.feature:114
-apiWebdavMove2/moveFile.feature:115
-apiWebdavMove2/moveFile.feature:162
-apiWebdavMove2/moveFile.feature:163
apiWebdavMove2/moveFile.feature:209
apiWebdavMove2/moveFile.feature:210
-apiWebdavMove2/moveFile.feature:231
-apiWebdavMove2/moveFile.feature:232
apiWebdavMove2/moveFile.feature:281
apiWebdavMove2/moveFile.feature:282
-apiWebdavMove2/moveFile.feature:303
-apiWebdavMove2/moveFile.feature:304
-apiWebdavMove2/moveFile.feature:305
-apiWebdavMove2/moveFile.feature:306
-apiWebdavMove2/moveFile.feature:307
-apiWebdavMove2/moveFile.feature:308
-apiWebdavMove2/moveFile.feature:309
-apiWebdavMove2/moveFile.feature:310
-apiWebdavMove2/moveFile.feature:311
-apiWebdavMove2/moveFile.feature:312
-apiWebdavMove2/moveFile.feature:313
-apiWebdavMove2/moveFile.feature:314
-apiWebdavOperations/deleteFile.feature:19
-apiWebdavOperations/deleteFile.feature:20
-apiWebdavOperations/deleteFile.feature:33
-apiWebdavOperations/deleteFile.feature:34
-apiWebdavOperations/deleteFile.feature:45
-apiWebdavOperations/deleteFile.feature:46
-apiWebdavOperations/deleteFile.feature:47
-apiWebdavOperations/deleteFile.feature:48
-apiWebdavOperations/deleteFile.feature:49
-apiWebdavOperations/deleteFile.feature:50
-apiWebdavOperations/deleteFile.feature:51
-apiWebdavOperations/deleteFile.feature:52
-apiWebdavOperations/deleteFile.feature:53
-apiWebdavOperations/deleteFile.feature:54
-apiWebdavOperations/deleteFile.feature:55
-apiWebdavOperations/deleteFile.feature:56
-apiWebdavOperations/deleteFile.feature:66
-apiWebdavOperations/deleteFile.feature:67
-apiWebdavOperations/deleteFile.feature:68
-apiWebdavOperations/deleteFile.feature:69
-apiWebdavOperations/deleteFile.feature:70
-apiWebdavOperations/deleteFile.feature:71
-apiWebdavOperations/deleteFolderContents.feature:31
-apiWebdavOperations/deleteFolderContents.feature:32
-apiWebdavOperations/downloadFile.feature:19
-apiWebdavOperations/downloadFile.feature:20
-apiWebdavOperations/downloadFile.feature:40
-apiWebdavOperations/downloadFile.feature:41
-apiWebdavOperations/downloadFile.feature:60
-apiWebdavOperations/downloadFile.feature:61
-apiWebdavOperations/downloadFile.feature:87
-apiWebdavOperations/downloadFile.feature:126
-apiWebdavOperations/downloadFile.feature:127
-apiWebdavOperations/downloadFile.feature:128
-apiWebdavOperations/downloadFile.feature:129
-apiWebdavOperations/downloadFile.feature:130
-apiWebdavOperations/downloadFile.feature:131
-apiWebdavProperties1/copyFile.feature:22
-apiWebdavProperties1/copyFile.feature:23
-apiWebdavProperties1/copyFile.feature:33
-apiWebdavProperties1/copyFile.feature:34
-apiWebdavProperties1/copyFile.feature:45
-apiWebdavProperties1/copyFile.feature:46
-apiWebdavProperties1/copyFile.feature:183
-apiWebdavProperties1/copyFile.feature:184
-apiWebdavProperties2/getFileProperties.feature:19
-apiWebdavProperties2/getFileProperties.feature:20
-apiWebdavProperties2/getFileProperties.feature:21
-apiWebdavProperties2/getFileProperties.feature:22
-apiWebdavProperties2/getFileProperties.feature:23
-apiWebdavProperties2/getFileProperties.feature:24
-apiWebdavProperties2/getFileProperties.feature:25
-apiWebdavProperties2/getFileProperties.feature:26
-apiWebdavProperties2/getFileProperties.feature:38
-apiWebdavProperties2/getFileProperties.feature:42
-apiWebdavProperties2/getFileProperties.feature:58
-apiWebdavProperties2/getFileProperties.feature:62
-apiWebdavProperties2/getFileProperties.feature:65
-apiWebdavProperties2/getFileProperties.feature:69
-apiWebdavProperties2/getFileProperties.feature:81
-apiWebdavProperties2/getFileProperties.feature:82
-apiWebdavProperties2/getFileProperties.feature:83
-apiWebdavProperties2/getFileProperties.feature:84
-apiWebdavProperties2/getFileProperties.feature:85
-apiWebdavProperties2/getFileProperties.feature:86
-apiWebdavProperties2/getFileProperties.feature:87
-apiWebdavProperties2/getFileProperties.feature:88
-apiWebdavProperties2/getFileProperties.feature:89
-apiWebdavProperties2/getFileProperties.feature:90
-apiWebdavProperties2/getFileProperties.feature:339
-apiWebdavProperties2/getFileProperties.feature:340
-apiWebdavProperties2/getFileProperties.feature:351
-apiWebdavProperties2/getFileProperties.feature:352
-apiWebdavProperties2/getFileProperties.feature:363
-apiWebdavProperties2/getFileProperties.feature:364
-apiWebdavUpload1/uploadFile.feature:20
-apiWebdavUpload1/uploadFile.feature:21
-apiWebdavUpload1/uploadFile.feature:22
-apiWebdavUpload1/uploadFile.feature:23
-apiWebdavUpload1/uploadFile.feature:24
-apiWebdavUpload1/uploadFile.feature:25
-apiWebdavUpload1/uploadFile.feature:26
-apiWebdavUpload1/uploadFile.feature:27
-apiWebdavUpload1/uploadFile.feature:35
-apiWebdavUpload1/uploadFile.feature:36
-apiWebdavUpload1/uploadFile.feature:37
-apiWebdavUpload1/uploadFile.feature:38
-apiWebdavUpload1/uploadFile.feature:61
-apiWebdavUpload1/uploadFile.feature:62
-apiWebdavUpload1/uploadFile.feature:63
-apiWebdavUpload1/uploadFile.feature:64
-apiWebdavUpload1/uploadFile.feature:65
-apiWebdavUpload1/uploadFile.feature:66
-apiWebdavUpload1/uploadFile.feature:75
-apiWebdavUpload1/uploadFile.feature:76
-apiWebdavUpload1/uploadFile.feature:77
-apiWebdavUpload1/uploadFile.feature:78
-apiWebdavUpload1/uploadFile.feature:79
-apiWebdavUpload1/uploadFile.feature:80
-apiWebdavUpload1/uploadFile.feature:81
-apiWebdavUpload1/uploadFile.feature:82
-apiWebdavUpload1/uploadFile.feature:83
-apiWebdavUpload1/uploadFile.feature:84
-apiWebdavUpload1/uploadFile.feature:123
-apiWebdavUpload1/uploadFile.feature:124
-apiWebdavUpload1/uploadFile.feature:125
-apiWebdavUpload1/uploadFile.feature:126
-apiWebdavUpload1/uploadFile.feature:127
-apiWebdavUpload1/uploadFile.feature:128
-apiWebdavUpload1/uploadFile.feature:129
-apiWebdavUpload1/uploadFile.feature:130
-apiWebdavUpload1/uploadFile.feature:131
-apiWebdavUpload1/uploadFile.feature:132
-apiWebdavUpload1/uploadFile.feature:133
apiWebdavUpload1/uploadFile.feature:144
apiWebdavUpload1/uploadFile.feature:145
apiWebdavUpload1/uploadFile.feature:157
@@ -400,6 +202,8 @@
apiVersions/fileVersions.feature:288
apiVersions/fileVersions.feature:362
apiVersions/fileVersions.feature:373
+apiWebdavProperties1/copyFile.feature:146
+apiWebdavProperties1/copyFile.feature:147
apiWebdavProperties2/getFileProperties.feature:376
apiWebdavProperties2/getFileProperties.feature:377
make: *** [Makefile:207: test-acceptance-api] Fehler 1
\ Kein Zeilenumbruch am Dateiende. |
all the removed lines are tests that are no longer failing, so that is a huge ➕
Then there are two tests that no longer pass:
investigating |
The failing lines are about ocs status codes: https://github.com/owncloud/core/blob/33c64ea3d56ec20e5d0cbc0f745ed2c04589b7f8/tests/acceptance/features/apiSharePublicLink1/deletePublicLinkShare.feature#L40-L54 I think we can safely tag because a lot of tests for public links are failing as well. |
note PR #461 - there is now an expected-failures file for EOS. So if we can create a drone pipeline in CI to run with EOS storage then we can independently adjust the expected failures, and have it run with each PR. |
…-storage [Tests-Only] Implement separate expected-failures files for OC and EOS storage
With EOS storage backend, the new WebDAV API doesn't work. The old API seems to work fine.
Here's an example of deleting a folder
Using the old WebDav API:
And using the new API.
The Logs in the server
Originally posted by @dpakach in #409 (comment)
The text was updated successfully, but these errors were encountered: