Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back logtostderr for swagger in Makefiles #223

Closed
butonic opened this issue Apr 24, 2020 · 5 comments · Fixed by #1912
Closed

Bring back logtostderr for swagger in Makefiles #223

butonic opened this issue Apr 24, 2020 · 5 comments · Fixed by #1912
Labels
Category:Defect Existing functionality is not working as expected Type:Bug Type:Technical-Debt

Comments

@butonic
Copy link
Member

butonic commented Apr 24, 2020

swagger does support logtostderr=true but we removed it

swagger_out=logtostderr=true:pkg/proto/v0 is fine
@PVince81
Copy link
Contributor

would be good to add clearer instructions and context about what needs to be done

@PVince81
Copy link
Contributor

PVince81 commented Apr 30, 2020 •
edited
Loading

@butonic any more instructions ? seems to require too much insider knowledge to get started as "good first issue"

@IljaN
Copy link
Member

IljaN commented Apr 30, 2020 •
edited
Loading

I assume grepping trough all ocis-repos for swagger_out= and re-adding swagger_out=logtostderr=true...

@IljaN
Copy link
Member

IljaN commented Apr 30, 2020

Basically a revert of those changes: owncloud/ocis-konnectd@c6c28c4#diff-b67911656ef5d18c4ae36cb6741b7965R196

refs pushed a commit that referenced this issue Sep 18, 2020
Merge pull request #223 from owncloud/ci-test
2b94f09 
[Tests-Only] Fix upload UI tests in CI
@refs
Copy link
Member

refs commented Jan 12, 2021

staled. more description needed.

@settings settings bot removed the bug label Jan 12, 2021
@refs refs changed the title bring back logtostderr for swagger in Makefiles Bring back logtostderr for swagger in Makefiles Jan 13, 2021
@refs refs added Category:Defect Existing functionality is not working as expected Type:Technical-Debt labels Jan 13, 2021
@settings settings bot removed the p3-medium label Apr 7, 2021
@wkloucek wkloucek mentioned this issue Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category:Defect Existing functionality is not working as expected Type:Bug Type:Technical-Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add logtostderr=true to protobuf generation owncloud/ocis
4 participants
@IljaN @PVince81 @butonic @refs