XML properties in webdav response not properly encoded

[dpakach]

On the xml webdav responses some properties are not properly encoded
for example

filename	expected value (Value returned by oc10)	Actual value
/folder &2.txt	webdav/file%20%262.txt	webdav/file%20&2.txt
/C++ folder	webdav/C%2b%2b%20folder	webdav/C++%20folder/

[PVince81]

is this not the same as owncloud/ocis-reva#122 ?

I see that issue is closed but the tests are still skipped

[PVince81]

I see you mentionned this in owncloud/core#37388

In the future please always create connections between the tickets to make it easier to find the contexts

[PVince81]

never mind, it was referenced indirectly.

usually I think it can be useful to add a sentence in the top post that says where this was discovered and what it related to, to avoid confusion

[PVince81]

seems we're using Golang's URL.EscapedPath which apparently decided to not encode the spaces and plus signs

[PVince81]

we could use url.QueryEscape() but it needs to done individually on each path section

[PVince81]

so I just tried it locally but it encoded with lower case instead of upper case. "%2d" instead of "%2D", so the test also fails 😞

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[phil-davis]

@dpakach is this still an issue?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[phil-davis]

@dpakach is this still a problem?
I don't see this issue mentioned in expected-failures.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

[pascalwengerter]

Reopening as technical debt until closed by someone that confirms it's fixed

[phil-davis]

@dpakach I assigned you and put this in the QA Project so that you will noticed it. Please check - if it is fixed, then close. Otherwise mention what the current remaining issue(s) are.

[dpakach]

Just checked on the latest master of ocis. Can confirm that it has been fixed.

  <d:response>
    <d:href>/remote.php/dav/files/admin/C%2b%2b%20folder/</d:href>
  </d:response>
  <d:response>
    <d:href>/remote.php/dav/files/admin/folder%20%262.txt/</d:href>
  </d:response>