Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Update issue tags for ocis tags #37388

Merged
merged 1 commit into from
May 20, 2020
Merged

[Tests-Only] Update issue tags for ocis tags #37388

merged 1 commit into from
May 20, 2020

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented May 14, 2020 •
edited
Loading

Description

Unskip ocis tests for custom href properties in webdav responses.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented May 14, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9607406). Click here to learn what that means.
The diff coverage is n/a.

@dpakach dpakach marked this pull request as ready for review May 19, 2020 09:05
@dpakach dpakach requested a review from individual-it May 19, 2020 09:05
@dpakach dpakach self-assigned this May 19, 2020
@dpakach dpakach force-pushed the unskip-ocis-reva-222 branch from a2f9eda to 0d3ce1f Compare May 19, 2020 09:10
@dpakach dpakach marked this pull request as draft May 19, 2020 10:00
@individual-it
Copy link
Member

please make a PR to OCIS and OCIS-REVA to prove that it works there

@dpakach
Copy link
Contributor Author

dpakach commented May 19, 2020

please make a PR to OCIS and OCIS-REVA to prove that it works there

@individual-it The issue is closed but seems like it is not properly fixed yet. Some tests are failing still

@dpakach dpakach force-pushed the unskip-ocis-reva-222 branch from 0d3ce1f to b79d4a2 Compare May 20, 2020 05:21
@dpakach dpakach marked this pull request as ready for review May 20, 2020 05:22
@dpakach dpakach requested a review from individual-it May 20, 2020 05:22
@individual-it
Copy link
Member

do we need to reopen owncloud/ocis-reva#122 ?

@dpakach
Copy link
Contributor Author

dpakach commented May 20, 2020

do we need to reopen owncloud/ocis-reva#122 ?owncloud/ocis-reva#122

No I think that was a different issue. I have opened new one in owncloud/ocis-reva#214

@dpakach dpakach changed the title [Tests-Only] Unskip ocis tests for ocis reva issue 122 [Tests-Only] Update issue tags for ocis tags May 20, 2020
@phil-davis phil-davis merged commit 776f6f2 into master May 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the unskip-ocis-reva-222 branch May 20, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

Assignees

@dpakach dpakach

Labels
3 - To Review dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpakach @individual-it @phil-davis