Merge pull request #1070 from owncloud/remove_duplicate_STORAGE_FRONT…

…END_PUBLIC_URL add note to duplicate STORAGE_FRONTEND_PUBLIC_URL
owncloud · Dec 14, 2020 · ee24050 · ee24050
2 parents 0722d45 + 5fd46a9
commit ee24050
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/storage/pkg/flagset/frontend.go b/storage/pkg/flagset/frontend.go
@@ -73,6 +73,9 @@ func FrontendWithConfig(cfg *config.Config) []cli.Flag {
 			EnvVars:     []string{"STORAGE_FRONTEND_HTTP_ADDR"},
 			Destination: &cfg.Reva.Frontend.HTTPAddr,
 		},
+		// please note that STORAGE_FRONTEND_PUBLIC_URL is also defined in
+		// storage/pkg/flagset/gateway.go because this setting may be consumed
+		// by both the gateway and frontend service
 		&cli.StringFlag{
 			Name:        "public-url",
 			Value:       "https://localhost:9200",

diff --git a/storage/pkg/flagset/gateway.go b/storage/pkg/flagset/gateway.go
@@ -139,6 +139,9 @@ func GatewayWithConfig(cfg *config.Config) []cli.Flag {
 			Destination: &cfg.Reva.StorageRegistry.HomeProvider,
 		},
 
+		// please note that STORAGE_FRONTEND_PUBLIC_URL is also defined in
+		// storage/pkg/flagset/frontend.go because this setting may be consumed
+		// by both the gateway and frontend service
 		&cli.StringFlag{
 			Name:        "public-url",
 			Value:       "https://localhost:9200",