Merge pull request #3376 from rhafer/graph-user-patch

graph: Allow PATCH on user without 'mail' in body
owncloud · Mar 29, 2022 · ec0b3b1 · ec0b3b1
2 parents c34503e + 517356f
commit ec0b3b1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/changelog/unreleased/graph-patch-mail.md b/changelog/unreleased/graph-patch-mail.md
@@ -0,0 +1,6 @@
+Bugfix: Fix request validation on GraphAPI User updates
+
+Fix PATCH on graph/v1.0/users when no 'mail' attribute
+is present in the request body
+
+https://github.com/owncloud/ocis/issues/3167
diff --git a/graph/pkg/service/v0/users.go b/graph/pkg/service/v0/users.go
@@ -180,11 +180,12 @@ func (g Graph) PatchUser(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	mail := changes.GetMail()
-	if !isValidEmail(mail) {
-		errorcode.InvalidRequest.Render(w, r, http.StatusBadRequest,
-			fmt.Sprintf("'%s' is not a valid email address", mail))
-		return
+	if mail, ok := changes.GetMailOk(); ok {
+		if !isValidEmail(*mail) {
+			errorcode.InvalidRequest.Render(w, r, http.StatusBadRequest,
+				fmt.Sprintf("'%s' is not a valid email address", *mail))
+			return
+		}
 	}
 
 	u, err := g.identityBackend.UpdateUser(r.Context(), nameOrID, *changes)