Address reviews

Signed-off-by: Swikriti Tripathi <[email protected]>
owncloud · Jan 11, 2024 · e07a65a · e07a65a
1 parent 88fa41d
commit e07a65a
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/tests/acceptance/features/bootstrap/SharingNgContext.php b/tests/acceptance/features/bootstrap/SharingNgContext.php
@@ -352,12 +352,10 @@ public function removeSharePermissionOfAResource(
 		$itemId = ($resourceType === 'folder')
 			? $this->spacesContext->getResourceId($sharer, $space, $resource)
 			: $this->spacesContext->getFileId($sharer, $space, $resource);
-		$permId = null;
-		if ($shareType === 'link') {
-			$permId = $this->featureContext->shareNgGetLastCreatedLinkShareID();
-		} else {
-			$permId = $this->featureContext->shareNgGetLastCreatedUserGroupShareID();
-		}
+
+		$permId = ($shareType === 'link')
+			? $this->featureContext->shareNgGetLastCreatedLinkShareID()
+			: $this->featureContext->shareNgGetLastCreatedUserGroupShareID();
 		return
 			GraphHelper::deleteSharePermission(
 				$this->featureContext->getBaseUrl(),