Removed scenarios tagged with notToImplementOnOcis tag

owncloud · Feb 14, 2023 · d8eefe9 · d8eefe9
1 parent b7ec7c9
commit d8eefe9
Show file tree

Hide file tree

Showing 65 changed files with 13 additions and 5,265 deletions.
diff --git a/.drone.star b/.drone.star
@@ -848,7 +848,7 @@ def wopiValidatorTests(ctx, storage, accounts_hash_difficulty = 4):
 
 def coreApiTests(ctx, part_number = 1, number_of_parts = 1, storage = "ocis", accounts_hash_difficulty = 4):
     early_fail = config["apiTests"]["earlyFail"] if "earlyFail" in config["apiTests"] else False
-    filterTags = "~@skipOnGraph&&~@skipOnOcis&&~@notToImplementOnOCIS&&~@toImplementOnOCIS&&~comments-app-required&&~@federation-app-required&&~@notifications-app-required&&~systemtags-app-required&&~@local_storage&&~@skipOnOcis-%s-Storage&&~@caldav&&~@carddav" % ("OC" if storage == "owncloud" else "OCIS")
+    filterTags = "~@skipOnGraph&&~@skipOnOcis&&~@toImplementOnOCIS&&~comments-app-required&&~@federation-app-required&&~@notifications-app-required&&~systemtags-app-required&&~@local_storage&&~@skipOnOcis-%s-Storage&&~@caldav&&~@carddav" % ("OC" if storage == "owncloud" else "OCIS")
     expectedFailuresFile = "%s/tests/acceptance/expected-failures-API-on-%s-storage.md" % (dirs["base"], storage.upper())
 
     return {

diff --git a/tests/acceptance/config/behat-core.yml b/tests/acceptance/config/behat-core.yml
@@ -304,17 +304,6 @@ default:
         - WebDavLockingContext:
         - WebDavPropertiesContext:
 
-    coreApiWebdavLocks3:
-      paths:
-        - "%paths.base%/../features/coreApiWebdavLocks3"
-      context: *common_ldap_suite_context
-      contexts:
-        - FeatureContext: *common_feature_context_params
-        - OccContext:
-        - PublicWebDavContext:
-        - WebDavLockingContext:
-        - WebDavPropertiesContext:
-
     coreApiWebdavLocksUnlock:
       paths:
         - "%paths.base%/../features/coreApiWebdavLocksUnlock"

diff --git a/tests/acceptance/docker/src/run-tests.sh b/tests/acceptance/docker/src/run-tests.sh
@@ -12,7 +12,7 @@ then
     if [ "$STORAGE_DRIVER" = "ocis" ]
     then
         export OCIS_REVA_DATA_ROOT=''
-        export BEHAT_FILTER_TAGS='~@notToImplementOnOCIS&&~@toImplementOnOCIS&&~comments-app-required&&~@federation-app-required&&~@notifications-app-required&&~systemtags-app-required&&~@local_storage&&~@skipOnOcis-OCIS-Storage'
+        export BEHAT_FILTER_TAGS='~@toImplementOnOCIS&&~comments-app-required&&~@federation-app-required&&~@notifications-app-required&&~systemtags-app-required&&~@local_storage&&~@skipOnOcis-OCIS-Storage'
         export OCIS_SKELETON_STRATEGY='upload'
         export EXPECTED_FAILURES_FILE='/drone/src/tests/acceptance/expected-failures-API-on-OCIS-storage.md'
     elif [ "$STORAGE_DRIVER" = "s3ng" ]

diff --git a/tests/acceptance/features/coreApiAuth/webDavAuth.feature b/tests/acceptance/features/coreApiAuth/webDavAuth.feature
@@ -26,15 +26,3 @@ Feature: auth
     Examples:
       | dav_path              |
       | /dav/spaces/%spaceid% |
-
-  @smokeTest @notToImplementOnOCIS @issue-ocis-reva-28
-  Scenario: using WebDAV with token auth
-    Given a new client token for "Alice" has been generated
-    When user "Alice" requests "/remote.php/webdav" with "PROPFIND" using basic token auth
-    Then the HTTP status code should be "207"
-
-  @smokeTest  @notToImplementOnOCIS
-  Scenario: using WebDAV with browser session
-    Given a new browser session for "Alice" has been started
-    When the user requests "/remote.php/webdav" with "PROPFIND" using the browser session
-    Then the HTTP status code should be "207"
diff --git a/tests/acceptance/features/coreApiAuthOcs/ocsGETAuth.feature b/tests/acceptance/features/coreApiAuthOcs/ocsGETAuth.feature
@@ -149,100 +149,3 @@ Feature: auth
       | /ocs/v2.php/config |
     Then the HTTP status code of responses on all endpoints should be "200"
     And the OCS status code of responses on all endpoints should be "200"
-
-  @notToImplementOnOCIS @issue-ocis-reva-30 @issue-ocis-reva-28
-  Scenario: using OCS with token auth of a normal user
-    Given a new client token for "Alice" has been generated
-    When user "Alice" requests these endpoints with "GET" using basic token auth
-      | endpoint                                                    |
-      | /ocs/v1.php/apps/files_sharing/api/v1/remote_shares         |
-      | /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending |
-      | /ocs/v1.php/apps/files_sharing/api/v1/shares                |
-      | /ocs/v1.php/config                                          |
-      | /ocs/v1.php/privatedata/getattribute                        |
-    Then the HTTP status code of responses on all endpoints should be "200"
-    And the OCS status code of responses on all endpoints should be "100"
-    When user "Alice" requests these endpoints with "GET" using basic token auth
-      | endpoint                                                    |
-      | /ocs/v2.php/apps/files_sharing/api/v1/remote_shares         |
-      | /ocs/v2.php/apps/files_sharing/api/v1/remote_shares/pending |
-      | /ocs/v2.php/apps/files_sharing/api/v1/shares                |
-      | /ocs/v2.php/config                                          |
-      | /ocs/v2.php/privatedata/getattribute                        |
-    Then the HTTP status code of responses on all endpoints should be "200"
-    And the OCS status code of responses on all endpoints should be "200"
-    When user "Alice" requests these endpoints with "GET" using basic token auth
-      | endpoint                 |
-      | /ocs/v1.php/cloud/apps   |
-      | /ocs/v1.php/cloud/users  |
-      | /ocs/v1.php/cloud/groups |
-      | /ocs/v2.php/cloud/apps   |
-      | /ocs/v2.php/cloud/groups |
-      | /ocs/v2.php/cloud/users  |
-    Then the HTTP status code of responses on all endpoints should be "401"
-    And the OCS status code of responses on all endpoints should be "997"
-
-  @notToImplementOnOCIS
-  Scenario: using OCS with browser session of normal user
-    Given a new browser session for "Alice" has been started
-    When the user requests these endpoints with "GET" using a new browser session
-      | endpoint                                                    |
-      | /ocs/v1.php/apps/files_sharing/api/v1/remote_shares         |
-      | /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending |
-      | /ocs/v1.php/apps/files_sharing/api/v1/shares                |
-      | /ocs/v1.php/config                                          |
-      | /ocs/v1.php/privatedata/getattribute                        |
-    Then the HTTP status code of responses on all endpoints should be "200"
-    And the OCS status code of responses on all endpoints should be "100"
-    When the user requests these endpoints with "GET" using a new browser session
-      | endpoint                                                    |
-      | /ocs/v2.php/apps/files_sharing/api/v1/remote_shares         |
-      | /ocs/v2.php/apps/files_sharing/api/v1/remote_shares/pending |
-      | /ocs/v2.php/apps/files_sharing/api/v1/shares                |
-      | /ocs/v2.php/config                                          |
-      | /ocs/v2.php/privatedata/getattribute                        |
-    Then the HTTP status code of responses on all endpoints should be "200"
-    And the OCS status code of responses on all endpoints should be "200"
-    When the user requests these endpoints with "GET" using a new browser session
-      | endpoint                 |
-      | /ocs/v1.php/cloud/apps   |
-      | /ocs/v2.php/cloud/apps   |
-      | /ocs/v1.php/cloud/groups |
-      | /ocs/v2.php/cloud/groups |
-      | /ocs/v1.php/cloud/users  |
-      | /ocs/v2.php/cloud/users  |
-    Then the HTTP status code of responses on all endpoints should be "401"
-    And the OCS status code of responses on all endpoints should be "997"
-
-  @notToImplementOnOCIS
-  Scenario: using OCS with an app password of a normal user
-    Given a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user requests these endpoints with "GET" using the generated app password
-      | endpoint                                                    |
-      | /ocs/v1.php/apps/files_sharing/api/v1/remote_shares         |
-      | /ocs/v1.php/apps/files_sharing/api/v1/remote_shares/pending |
-      | /ocs/v1.php/apps/files_sharing/api/v1/shares                |
-      | /ocs/v1.php/config                                          |
-      | /ocs/v1.php/privatedata/getattribute                        |
-    Then the HTTP status code of responses on all endpoints should be "200"
-    And the OCS status code of responses on all endpoints should be "100"
-    When the user requests these endpoints with "GET" using the generated app password
-      | endpoint                                                    |
-      | /ocs/v2.php/apps/files_sharing/api/v1/remote_shares         |
-      | /ocs/v2.php/apps/files_sharing/api/v1/remote_shares/pending |
-      | /ocs/v2.php/apps/files_sharing/api/v1/shares                |
-      | /ocs/v2.php/config                                          |
-      | /ocs/v2.php/privatedata/getattribute                        |
-    Then the HTTP status code of responses on all endpoints should be "200"
-    And the OCS status code of responses on all endpoints should be "200"
-    When the user requests these endpoints with "GET" using the generated app password
-      | endpoint                 |
-      | /ocs/v1.php/cloud/apps   |
-      | /ocs/v2.php/cloud/apps   |
-      | /ocs/v1.php/cloud/groups |
-      | /ocs/v2.php/cloud/groups |
-      | /ocs/v1.php/cloud/users  |
-      | /ocs/v2.php/cloud/users  |
-    Then the HTTP status code of responses on all endpoints should be "401"
-    And the OCS status code of responses on all endpoints should be "997"
diff --git a/tests/acceptance/features/coreApiAuthWebDav/webDavCOPYAuth.feature b/tests/acceptance/features/coreApiAuthWebDav/webDavCOPYAuth.feature
@@ -133,35 +133,6 @@ Feature: COPY file/folder
       | /remote.php/dav/spaces/%spaceid%/PARENT/parent.txt |
     Then the HTTP status code of responses on all endpoints should be "401"
 
-  @notToImplementOnOCIS @issue-ocis-reva-37
-  Scenario: send COPY requests to webDav endpoints using token authentication should not work
-    Given token auth has been enforced
-    And a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user requests these endpoints with "COPY" using the generated app password about user "Alice"
-      | endpoint                                           |
-      | /remote.php/webdav/textfile0.txt                   |
-      | /remote.php/dav/files/%username%/textfile0.txt     |
-      | /remote.php/webdav/PARENT                          |
-      | /remote.php/dav/files/%username%/PARENT            |
-      | /remote.php/dav/files/%username%/PARENT/parent.txt |
-    Then the HTTP status code of responses on all endpoints should be "401"
-
-  @notToImplementOnOCIS @issue-ocis-reva-37
-  Scenario: send COPY requests to webDav endpoints using app password token as password
-    Given token auth has been enforced
-    And a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user "Alice" requests these endpoints with "COPY" with body "doesnotmatter" using basic auth and generated app password about user "Alice"
-      | endpoint                                           |
-      # The token was valid and accepted but the body is invalid so it gives 403
-      | /remote.php/webdav/textfile0.txt                   |
-      | /remote.php/dav/files/%username%/textfile1.txt     |
-      | /remote.php/dav/files/%username%/PARENT/parent.txt |
-      | /remote.php/webdav/PARENT                          |
-      | /remote.php/dav/files/%username%/FOLDER            |
-    Then the HTTP status code of responses on all endpoints should be "403"
-
   @skipOnOcV10
   Scenario: send COPY requests to webDav endpoints with body as normal user
     When user "Alice" requests these endpoints with "COPY" including body "doesnotmatter" about user "Alice"

diff --git a/tests/acceptance/features/coreApiAuthWebDav/webDavLOCKAuth.feature b/tests/acceptance/features/coreApiAuthWebDav/webDavLOCKAuth.feature
@@ -135,31 +135,3 @@ Feature: LOCK file/folder
       | /remote.php/dav/spaces/%spaceid%/PARENT            |
       | /remote.php/dav/spaces/%spaceid%/PARENT/parent.txt |
     Then the HTTP status code of responses on all endpoints should be "401"
-
-  @notToImplementOnOCIS @issue-ocis-reva-37
-  Scenario: send LOCK requests to webDav endpoints using token authentication should not work
-    Given token auth has been enforced
-    And a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user requests these endpoints with "LOCK" using the generated app password about user "Alice"
-      | endpoint                                           |
-      | /remote.php/webdav/textfile0.txt                   |
-      | /remote.php/dav/files/%username%/textfile0.txt     |
-      | /remote.php/webdav/PARENT                          |
-      | /remote.php/dav/files/%username%/PARENT            |
-      | /remote.php/dav/files/%username%/PARENT/parent.txt |
-    Then the HTTP status code of responses on all endpoints should be "401"
-
-  @notToImplementOnOCIS @issue-ocis-reva-37
-  Scenario: send LOCK requests to webDav endpoints using app password token as password
-    Given token auth has been enforced
-    And a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user "Alice" requests these endpoints with "LOCK" to get property "d:shared" using basic auth and generated app password about user "Alice"
-      | endpoint                                           |
-      | /remote.php/webdav/textfile0.txt                   |
-      | /remote.php/dav/files/%username%/textfile1.txt     |
-      | /remote.php/dav/files/%username%/PARENT/parent.txt |
-      | /remote.php/webdav/PARENT                          |
-      | /remote.php/dav/files/%username%/FOLDER            |
-    Then the HTTP status code of responses on all endpoints should be "200"
diff --git a/tests/acceptance/features/coreApiAuthWebDav/webDavMKCOLAuth.feature b/tests/acceptance/features/coreApiAuthWebDav/webDavMKCOLAuth.feature
@@ -153,31 +153,3 @@ Feature: create folder using MKCOL
       | /remote.php/dav/spaces/%spaceid%/PARENT            |
       | /remote.php/dav/spaces/%spaceid%/PARENT/parent.txt |
     Then the HTTP status code of responses on all endpoints should be "401"
-
-  @notToImplementOnOCIS @issue-ocis-reva-37
-  Scenario: send MKCOL requests to webDav endpoints using token authentication should not work
-    Given token auth has been enforced
-    And a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user requests these endpoints with "MKCOL" using the generated app password about user "Alice"
-      | endpoint                                           |
-      | /remote.php/webdav/textfile0.txt                   |
-      | /remote.php/dav/files/%username%/textfile0.txt     |
-      | /remote.php/webdav/PARENT                          |
-      | /remote.php/dav/files/%username%/PARENT            |
-      | /remote.php/dav/files/%username%/PARENT/parent.txt |
-    Then the HTTP status code of responses on all endpoints should be "401"
-
-  @notToImplementOnOCIS @issue-ocis-reva-37
-  Scenario: send MKCOL requests to webDav endpoints using app password token as password
-    Given token auth has been enforced
-    And a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user "Alice" requests these endpoints with "MKCOL" using basic auth and generated app password about user "Alice"
-      | endpoint                                       |
-      | /remote.php/webdav/newCol                      |
-      | /remote.php/dav/files/%username%/newCol1       |
-      | /remote.php/dav/files/%username%/PARENT/newCol |
-      | /remote.php/webdav/COL                         |
-      | /remote.php/dav/files/%username%/FOLDER/newCol |
-    Then the HTTP status code of responses on all endpoints should be "201"
diff --git a/tests/acceptance/features/coreApiAuthWebDav/webDavMOVEAuth.feature b/tests/acceptance/features/coreApiAuthWebDav/webDavMOVEAuth.feature
@@ -129,35 +129,6 @@ Feature: MOVE file/folder
       | /remote.php/dav/spaces/%spaceid%/PARENT/parent.txt |
     Then the HTTP status code of responses on all endpoints should be "401"
 
-  @notToImplementOnOCIS @issue-ocis-reva-37
-  Scenario: send MOVE requests to webDav endpoints using token authentication should not work
-    Given token auth has been enforced
-    And a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user requests these endpoints with "MOVE" using the generated app password about user "Alice"
-      | endpoint                                           |
-      | /remote.php/webdav/textfile0.txt                   |
-      | /remote.php/dav/files/%username%/textfile0.txt     |
-      | /remote.php/webdav/PARENT                          |
-      | /remote.php/dav/files/%username%/PARENT            |
-      | /remote.php/dav/files/%username%/PARENT/parent.txt |
-    Then the HTTP status code of responses on all endpoints should be "401"
-
-  @notToImplementOnOCIS @issue-ocis-reva-37
-  Scenario: send MOVE requests to webDav endpoints using app password token as password
-    Given token auth has been enforced
-    And a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user "Alice" requests these endpoints with "MOVE" with body "doesnotmatter" using basic auth and generated app password about user "Alice"
-      | endpoint                                           |
-      # The token was valid and accepted but the body is invalid so it gives 403
-      | /remote.php/webdav/textfile0.txt                   |
-      | /remote.php/dav/files/%username%/textfile1.txt     |
-      | /remote.php/dav/files/%username%/PARENT/parent.txt |
-      | /remote.php/webdav/PARENT                          |
-      | /remote.php/dav/files/%username%/FOLDER            |
-    Then the HTTP status code of responses on all endpoints should be "403"
-
   @skipOnOcV10
   Scenario: send MOVE requests to webDav endpoints with body as normal user
     When user "Alice" requests these endpoints with "MOVE" including body "doesnotmatter" about user "Alice"

diff --git a/tests/acceptance/features/coreApiAuthWebDav/webDavPOSTAuth.feature b/tests/acceptance/features/coreApiAuthWebDav/webDavPOSTAuth.feature
@@ -129,32 +129,3 @@ Feature: get file info using POST
       | /remote.php/dav/spaces/%spaceid%/PARENT            |
       | /remote.php/dav/spaces/%spaceid%/PARENT/parent.txt |
     Then the HTTP status code of responses on all endpoints should be "401"
-
-  @notToImplementOnOCIS @issue-ocis-reva-37
-  Scenario: send POST requests to webDav endpoints using token authentication should not work
-    Given token auth has been enforced
-    And a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user requests these endpoints with "POST" using the generated app password about user "Alice"
-      | endpoint                                           |
-      | /remote.php/webdav/textfile0.txt                   |
-      | /remote.php/dav/files/%username%/textfile0.txt     |
-      | /remote.php/webdav/PARENT                          |
-      | /remote.php/dav/files/%username%/PARENT            |
-      | /remote.php/dav/files/%username%/PARENT/parent.txt |
-    Then the HTTP status code of responses on all endpoints should be "401"
-
-  @notToImplementOnOCIS @issue-ocis-reva-37
-  Scenario: send POST requests to webDav endpoints using app password token as password
-    Given token auth has been enforced
-    And a new browser session for "Alice" has been started
-    And the user has generated a new app password named "my-client"
-    When the user "Alice" requests these endpoints with "POST" with body "doesnotmatter" using basic auth and generated app password about user "Alice"
-      | endpoint                                           |
-      # this method is not available so gives 501
-      | /remote.php/webdav/textfile0.txt                   |
-      | /remote.php/dav/files/%username%/textfile1.txt     |
-      | /remote.php/dav/files/%username%/PARENT/parent.txt |
-      | /remote.php/webdav/PARENT                          |
-      | /remote.php/dav/files/%username%/FOLDER            |
-    Then the HTTP status code of responses on all endpoints should be "501"