Merge pull request #10219 from kobergj/FixDeleteSharePanic

Fix panic when deleting ocm shares
owncloud · Oct 2, 2024 · d8a641f · d8a641f
2 parents 99e8082 + 6e7bafb
commit d8a641f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/changelog/unreleased/fix-delete-share-panic.md b/changelog/unreleased/fix-delete-share-panic.md
@@ -0,0 +1,5 @@
+Bugfix: Fix delete share panic
+
+Fixes a panic when deleting an ocm share
+
+https://github.com/owncloud/ocis/pull/10219
diff --git a/services/graph/pkg/service/v0/utils.go b/services/graph/pkg/service/v0/utils.go
@@ -500,10 +500,10 @@ func roleConditionForResourceType(ri *storageprovider.ResourceInfo) (string, err
 }
 
 func federatedRoleConditionForResourceType(ri *storageprovider.ResourceInfo) (string, error) {
-	switch {
-	case ri.Type == storageprovider.ResourceType_RESOURCE_TYPE_CONTAINER:
+	switch ri.GetType() {
+	case storageprovider.ResourceType_RESOURCE_TYPE_CONTAINER:
 		return unifiedrole.UnifiedRoleConditionFolderFederatedUser, nil
-	case ri.Type == storageprovider.ResourceType_RESOURCE_TYPE_FILE:
+	case storageprovider.ResourceType_RESOURCE_TYPE_FILE:
 		return unifiedrole.UnifiedRoleConditionFileFederatedUser, nil
 	default:
 		return "", errorcode.New(errorcode.InvalidRequest, "unsupported resource type for federated role")