address reviews

owncloud · Jan 9, 2024 · 7fd874b · 7fd874b
1 parent 6a0182a
commit 7fd874b
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 4 deletions.
diff --git a/tests/TestHelpers/GraphHelper.php b/tests/TestHelpers/GraphHelper.php
@@ -1702,6 +1702,40 @@ public static function updateLinkShare(
 		);
 	}
 
+	/**
+	 * @param string $baseUrl
+	 * @param string $xRequestId
+	 * @param string $user
+	 * @param string $password
+	 * @param string $spaceId
+	 * @param string $itemId
+	 * @param mixed $body
+	 * @param string $permissionsId
+	 *
+	 * @return ResponseInterface
+	 * @throws GuzzleException
+	 */
+	public static function setLinkSharePassword(
+		string $baseUrl,
+		string $xRequestId,
+		string $user,
+		string $password,
+		string $spaceId,
+		string $itemId,
+		$body,
+		string $permissionsId
+	): ResponseInterface {
+		$url = self::getBetaFullUrl($baseUrl, "drives/$spaceId/items/$itemId/permissions/$permissionsId/setPassword");
+		return HttpRequestHelper::post(
+			$url,
+			$xRequestId,
+			$user,
+			$password,
+			self::getRequestHeaders(),
+			$body
+		);
+	}
+
 	/**
 	 * @param string $baseUrl
 	 * @param string $xRequestId

diff --git a/tests/acceptance/features/bootstrap/Sharing.php b/tests/acceptance/features/bootstrap/Sharing.php
@@ -220,7 +220,7 @@ public function shareNgGetLastCreatedLinkShareToken(): string {
 	/**
 	 * @return string
 	 */
-	public function shareNgGetLastCreatedUserShareShareID(): string {
+	public function shareNgGetLastCreatedUserGroupShareID(): string {
 		$lastResponse = $this->shareNgGetLastCreatedUserGroupShare();
 		if (!isset($this->getJsonDecodedResponse($lastResponse)['value'][0]['id'])) {
 			throw new Error('Response did not contain share id for the last created share.');

diff --git a/tests/acceptance/features/bootstrap/SharingNgContext.php b/tests/acceptance/features/bootstrap/SharingNgContext.php
@@ -160,8 +160,8 @@ public function sendShareInvitation(string $user, TableNode $table): ResponseInt
 			$itemId,
 			$shareeId,
 			$rows['shareType'],
-			$role,
-			$permission,
+			$permissionsRole,
+			$permissionsAction,
 			$expireDate
 		);
 		if ($response->getStatusCode() === 200) {
@@ -354,7 +354,7 @@ public function userRemovesSharePermissionOfUserFromResourceOfSpaceUsingGraphAPI
 		$itemId = ($resourceType === 'folder')
 			? $this->spacesContext->getResourceId($sharer, $space, $resource)
 			: $this->spacesContext->getFileId($sharer, $space, $resource);
-		$permId = $this->featureContext->shareNgGetLastCreatedUserShareShareID();
+		$permId = $this->featureContext->shareNgGetLastCreatedUserGroupShareID();
 		$this->featureContext->setResponse(
 			GraphHelper::deleteSharePermission(
 				$this->featureContext->getBaseUrl(),