adding test for trying to enable sync with invalid remote item id

owncloud · Apr 22, 2024 · 5be52e2 · 5be52e2
1 parent 520aa9a
commit 5be52e2
Show file tree

Hide file tree

Showing 3 changed files with 123 additions and 0 deletions.
diff --git a/tests/acceptance/features/apiSharingNg/enableDisableShareSync.feature b/tests/acceptance/features/apiSharingNg/enableDisableShareSync.feature
@@ -297,3 +297,40 @@ Feature:  enable or disable sync of incoming shares
       | resource      |
       | textfile0.txt |
       | FolderToShare |
+
+  @issue-8724
+  Scenario: try to enable share sync of non-existing resource
+    When user "Brian" tries to enable share sync of non-existing resource using the Graph API
+    Then the HTTP status code should be "400"
+    And the JSON data of the response should match
+      """
+      {
+        "type": "object",
+        "required": ["error"],
+        "properties": {
+          "error": {
+            "type": "object",
+            "required": [
+              "code",
+              "innererror",
+              "message"
+            ],
+            "properties": {
+              "code" : {
+                "const": "invalidRequest"
+              },
+              "innererror" : {
+                "type": "object",
+                "required": [
+                  "date",
+                  "request-id"
+                ]
+              },
+              "message" : {
+                "const": "mounting share failed"
+              }
+            }
+          }
+        }
+      }
+      """
diff --git a/tests/acceptance/features/apiSharingNg/listPermissions.feature b/tests/acceptance/features/apiSharingNg/listPermissions.feature
@@ -1079,3 +1079,44 @@ Feature: List a sharing permissions
       | drive    |
       | Personal |
       | Shares   |
+
+
+  Scenario: try to lists the permissions of a project drive as a viewer
+    Given using spaces DAV path
+    And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
+    And user "Alice" has created a space "new-space" with the default quota using the Graph API
+    When user "Brian" tries to lists the permissions of space "new-space" using the Graph API
+    Then the HTTP status code should be "404"
+    And the JSON data of the response should match
+      """
+      {
+        "type": "object",
+        "required": ["error"],
+        "properties": {
+          "error": {
+            "type": "object",
+            "required": [
+              "code",
+              "innererror",
+              "message"
+            ],
+            "properties": {
+              "code": {
+                "const": "itemNotFound"
+              },
+              "innererror": {
+                "type": "object",
+                "required": [
+                  "date",
+                  "request-id"
+                ]
+              },
+              "message": {
+                "type":"pattern"
+                "enum": "stat: error: not found: ^%file_id_pattern%$"
+              }
+            }
+          }
+        }
+      }
+      """
diff --git a/tests/acceptance/features/bootstrap/SharingNgContext.php b/tests/acceptance/features/bootstrap/SharingNgContext.php
@@ -152,6 +152,31 @@ public function userListsThePermissionsOfSpaceUsingTheGraphApi($user, $space):vo
 		);
 	}
 
+	/**
+     * @When user :user tries to lists the permissions of space :space using the Graph API
+     */
+    public function userTriesToListsThePermissionsOfSpaceUsingTheGraphApi(string $user, string $space)
+    {
+		$spaceId = ($this->spacesContext->getSpaceByName($this->featureContext->getAdminUsername(), $space))["id"];
+
+		var_dump($spaceId,'a');
+
+		$itemId = $this->spacesContext->getResourceId("alice", $space,"");
+		var_dump($itemId,'b');
+
+		$this->featureContext->setResponse(
+				GraphHelper::getPermissionsList(
+				$this->featureContext->getBaseUrl(),
+				$this->featureContext->getStepLineRef(),
+				$user,
+				$this->featureContext->getPasswordForUser($user),
+				$spaceId,
+				$itemId
+			)
+		);
+    }
+
+
 	/**
 	 * @param string $user
 	 * @param TableNode $table
@@ -714,6 +739,26 @@ public function userEnablesSyncOfShareUsingTheGraphApi(string $user, string $sha
 		$this->featureContext->setResponse($response);
 	}
 
+	/**
+	 * @When user :user tries to enable share sync of non-existing resource using the Graph API
+	 *
+	 * @param string $user
+	 *
+	 * @return void
+	 */
+	public function userTriesToEnablsShareSyncOfNonExistingResourceUsingTheGraphApi(string $user):void {
+		$shareSpaceId = FeatureContext::SHARES_SPACE_ID;
+		$response =  GraphHelper::enableShareSync(
+			$this->featureContext->getBaseUrl(),
+			$this->featureContext->getStepLineRef(),
+			$this->featureContext->getActualUsername($user),
+			$this->featureContext->getPasswordForUser($user),
+			WebDavHelper::generateUUIDv4(),
+			$shareSpaceId
+		);
+		$this->featureContext->setResponse($response);
+	}
+
 	/**
 	 * @Then /^user "([^"]*)" should have sync (enabled|disabled) for share "([^"]*)"$/
 	 *