[test-only] new lock tests (#7595)

* add new lock tests * fix after review * Update WebDavLockingContext.php
owncloud · Oct 31, 2023 · 4577e85 · 4577e85
1 parent 804d17c
commit 4577e85
Show file tree

Hide file tree

Showing 5 changed files with 349 additions and 66 deletions.
diff --git a/tests/acceptance/config/behat.yml b/tests/acceptance/config/behat.yml
@@ -46,6 +46,7 @@ default:
         - SpacesTUSContext:
         - GraphContext:
         - OcisConfigContext:
+        - WebDavLockingContext:
 
     apiSpacesShares:
       paths:

diff --git a/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md b/tests/acceptance/expected-failures-localAPI-on-OCIS-storage.md
@@ -143,5 +143,16 @@ The expected failures in this file are from features in the owncloud/ocis repo.
 
 - [apiGraph/addUserToGroup.feature:420](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/addUserToGroup.feature#L420)
 
+### [500 error if viewer tries to lock file](https://github.com/owncloud/ocis/issues/7600)
+
+- [apiSpaces/lockFiles.feature:144](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/lockFiles.feature#L144)
+- [apiSpaces/lockFiles.feature:207](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/lockFiles.feature#L207)
+
+### [Shared file locking is not possible using different path](https://github.com/owncloud/ocis/issues/7599)
+
+- [apiSpaces/lockFiles.feature:179](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/lockFiles.feature#L179)
+- [apiSpaces/lockFiles.feature:180](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/lockFiles.feature#L180)
+- [apiSpaces/lockFiles.feature:181](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/lockFiles.feature#L181)
+
 Note: always have an empty line at the end of this file.
 The bash script that processes this file requires that the last line has a newline on the end.
diff --git a/tests/acceptance/features/apiSpaces/lockFiles.feature b/tests/acceptance/features/apiSpaces/lockFiles.feature
@@ -0,0 +1,217 @@
+Feature: lock files
+  As a user
+  I want to lock files
+
+  Background:
+    Given these users have been created with default attributes and without skeleton files:
+      | username |
+      | Alice    |
+      | Brian    |
+
+
+  Scenario Outline: lock a file
+    Given using <dav-path-version> DAV path
+    And user "Alice" has uploaded a file inside space "Alice Hansen" with content "some content" to "textfile.txt"
+    When user "Alice" locks file "textfile.txt" using the WebDAV API setting the following properties
+      | lockscope | exclusive |
+    Then the HTTP status code should be "200"
+    When user "Alice" sends PROPFIND request from the space "Alice Hansen" to the resource "textfile.txt" using the WebDAV API
+    Then the HTTP status code should be "207"
+    And the "PROPFIND" response to user "Alice" should contain a space "Alice Hansen" with these key and value pairs:
+      | key                                                  | value        |
+      | d:lockdiscovery/d:activelock/d:lockscope/d:exclusive |              |
+      | d:lockdiscovery/d:activelock/d:depth                 | Infinity     |
+      | d:lockdiscovery/d:activelock/d:timeout               | Infinity     |
+      | d:lockdiscovery/d:activelock/oc:ownername            | Alice Hansen |
+    Examples:
+      | dav-path-version |
+      | old              |
+      | new              |
+      | spaces           |
+
+
+  Scenario Outline: lock a file with a timeout
+    Given using <dav-path-version> DAV path
+    And user "Alice" has uploaded a file inside space "Alice Hansen" with content "some content" to "textfile.txt"
+    When user "Alice" locks file "textfile.txt" using the WebDAV API setting the following properties
+      | lockscope | exclusive   |
+      | timeout   | Second-5000 |
+    Then the HTTP status code should be "200"
+    When user "Alice" sends PROPFIND request from the space "Alice Hansen" to the resource "textfile.txt" using the WebDAV API
+    Then the HTTP status code should be "207"
+    And the "PROPFIND" response to user "Alice" should contain a space "Alice Hansen" with these key and value pairs:
+      | key                                                  | value        |
+      | d:lockdiscovery/d:activelock/d:lockscope/d:exclusive |              |
+      | d:lockdiscovery/d:activelock/d:depth                 | Infinity     |
+      | d:lockdiscovery/d:activelock/d:timeout               | Second-5000  |
+      | d:lockdiscovery/d:activelock/oc:ownername            | Alice Hansen |
+    Examples:
+      | dav-path-version |
+      | old              |
+      | new              |
+      | spaces           |
+
+
+  Scenario Outline: lock a file using file-id
+    Given user "Alice" has uploaded a file inside space "Alice Hansen" with content "some content" to "textfile.txt"
+    And we save it into "FILEID"
+    When user "Alice" locks file using file-id path "<dav-path>" using the WebDAV API setting the following properties
+      | lockscope | exclusive   |
+      | timeout   | Second-3600 |
+    Then the HTTP status code should be "200"
+    When user "Alice" sends PROPFIND request from the space "Alice Hansen" to the resource "textfile.txt" using the WebDAV API
+    Then the HTTP status code should be "207"
+    And the "PROPFIND" response to user "Alice" should contain a space "Alice Hansen" with these key and value pairs:
+      | key                                                  | value        |
+      | d:lockdiscovery/d:activelock/d:lockscope/d:exclusive |              |
+      | d:lockdiscovery/d:activelock/d:depth                 | Infinity     |
+      | d:lockdiscovery/d:activelock/d:timeout               | Second-3600  |
+      | d:lockdiscovery/d:activelock/oc:ownername            | Alice Hansen |
+    Examples:
+      | dav-path                          |
+      | /remote.php/dav/spaces/<<FILEID>> |
+      | /dav/spaces/<<FILEID>>            |
+
+
+  Scenario Outline: user cannot lock file twice
+    Given using <dav-path-version> DAV path
+    And user "Alice" has uploaded a file inside space "Alice Hansen" with content "some content" to "textfile.txt"
+    And user "Alice" has locked file "textfile.txt" setting the following properties
+      | lockscope | exclusive |
+    When user "Alice" tries to lock file "textfile.txt" using the WebDAV API setting the following properties
+      | lockscope | exclusive |
+    Then the HTTP status code should be "423"
+    Examples:
+      | dav-path-version |
+      | old              |
+      | new              |
+      | spaces           |
+
+
+  Scenario Outline: lock a file in the project space
+    Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
+    And using spaces DAV path
+    And user "Alice" has created a space "Project" with the default quota using the GraphApi
+    And user "Alice" has uploaded a file inside space "Project" with content "some content" to "textfile.txt"
+    And user "Alice" has shared a space "Project" with settings:
+      | shareWith | Brian  |
+      | role      | <role> |
+    When user "Brian" locks file "textfile.txt" inside the space "Project" using the WebDAV API setting the following properties
+      | lockscope | exclusive   |
+      | timeout   | Second-3600 |
+    Then the HTTP status code should be "200"
+    When user "Brian" sends PROPFIND request from the space "Project" to the resource "textfile.txt" using the WebDAV API
+    Then the HTTP status code should be "207"
+    And the "PROPFIND" response to user "Brian" should contain a space "Project" with these key and value pairs:
+      | key                                                  | value        |
+      | d:lockdiscovery/d:activelock/d:lockscope/d:exclusive |              |
+      | d:lockdiscovery/d:activelock/d:depth                 | Infinity     |
+      | d:lockdiscovery/d:activelock/d:timeout               | Second-3600  |
+      | d:lockdiscovery/d:activelock/oc:ownername            | Brian Murphy |
+    Examples:
+      | role    |
+      | manager |
+      | editor  |
+
+
+  Scenario Outline: lock a file in the project space using file-id
+    Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
+    And using spaces DAV path
+    And user "Alice" has created a space "Project" with the default quota using the GraphApi
+    And user "Alice" has uploaded a file inside space "Project" with content "some content" to "textfile.txt"
+    And we save it into "FILEID"
+    And user "Alice" has shared a space "Project" with settings:
+      | shareWith | Brian  |
+      | role      | <role> |
+    When user "Brian" locks file using file-id path "<dav-path>" using the WebDAV API setting the following properties
+      | lockscope | exclusive   |
+      | timeout   | Second-3600 |
+    Then the HTTP status code should be "200"
+    When user "Brian" sends PROPFIND request from the space "Project" to the resource "textfile.txt" using the WebDAV API
+    Then the HTTP status code should be "207"
+    And the "PROPFIND" response to user "Brian" should contain a space "Project" with these key and value pairs:
+      | key                                                  | value        |
+      | d:lockdiscovery/d:activelock/d:lockscope/d:exclusive |              |
+      | d:lockdiscovery/d:activelock/d:depth                 | Infinity     |
+      | d:lockdiscovery/d:activelock/d:timeout               | Second-3600  |
+      | d:lockdiscovery/d:activelock/oc:ownername            | Brian Murphy |
+    Examples:
+      | role    | dav-path                          |
+      | manager | /remote.php/dav/spaces/<<FILEID>> |
+      | editor  | /dav/spaces/<<FILEID>>            |
+
+
+  Scenario: viewer cannot lock a file in the project space
+    Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
+    And using spaces DAV path
+    And user "Alice" has created a space "Project" with the default quota using the GraphApi
+    And user "Alice" has uploaded a file inside space "Project" with content "some content" to "textfile.txt"
+    And we save it into "FILEID"
+    And user "Alice" has shared a space "Project" with settings:
+      | shareWith | Brian  |
+      | role      | viewer |
+    When user "Brian" locks file "textfile.txt" inside the space "Project" using the WebDAV API setting the following properties
+      | lockscope | exclusive |
+    Then the HTTP status code should be "403"
+    When user "Brian" locks file using file-id path "/dav/spaces/<<FILEID>>" using the WebDAV API setting the following properties
+      | lockscope | exclusive |
+    Then the HTTP status code should be "403"
+
+
+  Scenario Outline: lock a file in the shares
+    Given using <dav-path-version> DAV path
+    And user "Alice" has uploaded a file inside space "Alice Hansen" with content "some content" to "textfile.txt"
+    And user "Alice" has created a share inside of space "Alice Hansen" with settings:
+      | path      | textfile.txt |
+      | shareWith | Brian        |
+      | role      | editor       |
+    When user "Brian" locks file "/Shares/textfile.txt" using the WebDAV API setting the following properties
+      | lockscope | exclusive |
+    Then the HTTP status code should be "200"
+    When user "Alice" sends PROPFIND request from the space "Alice Hansen" to the resource "textfile.txt" using the WebDAV API
+    Then the HTTP status code should be "207"
+    And the "PROPFIND" response to user "Alice" should contain a space "Alice Hansen" with these key and value pairs:
+      | key                                                  | value        |
+      | d:lockdiscovery/d:activelock/d:lockscope/d:exclusive |              |
+      | d:lockdiscovery/d:activelock/oc:ownername            | Brian Murphy |
+    Examples:
+      | dav-path-version |
+      | old              |
+      | new              |
+      | spaces           |
+
+
+  Scenario Outline: lock a file in the shares using file-id
+    Given user "Alice" has uploaded a file inside space "Alice Hansen" with content "some content" to "textfile.txt"
+    And we save it into "FILEID"
+    And user "Alice" has created a share inside of space "Alice Hansen" with settings:
+      | path      | textfile.txt |
+      | shareWith | Brian        |
+      | role      | editor       |
+    When user "Brian" locks file using file-id path "<dav-path>" using the WebDAV API setting the following properties
+      | lockscope | exclusive   |
+      | timeout   | Second-3600 |
+    Then the HTTP status code should be "200"
+    When user "Alice" sends PROPFIND request from the space "Alice Hansen" to the resource "textfile.txt" using the WebDAV API
+    Then the HTTP status code should be "207"
+    And the "PROPFIND" response to user "Alice" should contain a space "Alice Hansen" with these key and value pairs:
+      | key                                                  | value        |
+      | d:lockdiscovery/d:activelock/d:lockscope/d:exclusive |              |
+      | d:lockdiscovery/d:activelock/oc:ownername            | Brian Murphy |
+    Examples:
+      | dav-path                          |
+      | /remote.php/dav/spaces/<<FILEID>> |
+      | /dav/spaces/<<FILEID>>            |
+
+
+   Scenario: viewer cannot lock a file in the shares using file-id
+    Given user "Alice" has uploaded a file inside space "Alice Hansen" with content "some content" to "textfile.txt"
+    And we save it into "FILEID"
+    And user "Alice" has created a share inside of space "Alice Hansen" with settings:
+      | path      | textfile.txt |
+      | shareWith | Brian        |
+      | role      | viewer       |
+    When user "Brian" locks file using file-id path "<dav-path>" using the WebDAV API setting the following properties
+      | lockscope | exclusive   |
+    Then the HTTP status code should be "403"
+
diff --git a/tests/acceptance/features/bootstrap/SpacesContext.php b/tests/acceptance/features/bootstrap/SpacesContext.php
@@ -3439,7 +3439,7 @@ public function searchResultShouldContainSpace(string $user, string $spaceName):
 	 */
 	public function userSendsPropfindRequestToSpace(string $user, string $spaceName, ?string $resource = ""): void {
 		$this->setSpaceIDByName($user, $spaceName);
-		$properties = ['oc:permissions','oc:file-parent','oc:fileid','oc:share-types','oc:privatelink','d:resourcetype','oc:size','oc:name','d:getcontenttype', 'oc:tags'];
+		$properties = ['oc:permissions','oc:file-parent','oc:fileid','oc:share-types','oc:privatelink','d:resourcetype','oc:size','oc:name','d:getcontenttype','oc:tags','d:lockdiscovery','d:activelock'];
 		$this->featureContext->setResponse(
 			WebDavHelper::propfind(
 				$this->featureContext->getBaseUrl(),
@@ -3473,6 +3473,7 @@ public function theResponseShouldContainSpace(string $method, string $space, Tab
 
 	/**
 	 * @Then /^the "([^"]*)" response to user "([^"]*)" should contain a mountpoint "([^"]*)" with these key and value pairs:$/
+	 * @Then /^the "([^"]*)" response to user "([^"]*)" should contain a space "([^"]*)" with these key and value pairs:$/
 	 *
 	 * @param string $method # method should be either PROPFIND or REPORT
 	 * @param string $user
@@ -3540,6 +3541,18 @@ public function theResponseShouldContain(string $method, string $user, string $s
 					$actualTags = \sort($actualTags);
 					Assert::assertEquals($expectedTags, $actualTags, "wrong $findItem in the response");
 					break;
+				case "d:lockdiscovery/d:activelock/d:timeout":
+					if ($value === "Infinity") {
+						Assert::assertEquals($value, $responseValue, "wrong $findItem in the response");
+					} else {
+						// some time may be required between a lock and propfind request.
+						$responseValue = explode('-', $responseValue);
+						$responseValue = \intval($responseValue[1]);
+						$value = explode('-', $value);
+						$value = \intval($value[1]);
+						Assert::assertTrue($responseValue >= ($value - 3));
+					}
+					break;
 				default:
 					Assert::assertEquals($value, $responseValue, "wrong $findItem in the response");
 					break;