Skip to content

Commit

Permalink
add skip on stable tag (#5940)
Browse files Browse the repository at this point in the history
  • Loading branch information
SwikritiT authored Mar 28, 2023
1 parent 382aa58 commit 270bf06
Show file tree
Hide file tree
Showing 11 changed files with 66 additions and 61 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ The expected failures in this file are from features in the owncloud/ocis repo.
- [apiGraph/createGroupCaseSensitive.feature:21](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createGroupCaseSensitive.feature#L21)
- [apiGraph/createGroupCaseSensitive.feature:22](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createGroupCaseSensitive.feature#L22)
- [apiGraph/createGroup.feature:26](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createGroup.feature#L26)
- [apiGraph/createUser.feature:29](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createUser.feature#L29)
- [apiGraph/createUser.feature:62](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createUser.feature#L62)
- [apiGraph/createUser.feature:35](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createUser.feature#L35)
- [apiGraph/createUser.feature:66](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/createUser.feature#L66)

### [PROPFIND on accepted shares with identical names containing brackets exit with 404](https://github.com/owncloud/ocis/issues/4421)
- [apiSpacesShares/changingFilesShare.feature:12](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/changingFilesShare.feature#L12)
Expand Down Expand Up @@ -105,7 +105,6 @@ The expected failures in this file are from features in the owncloud/ocis repo.
- [apiGraph/getUser.feature:40](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L40)
- [apiGraph/getUser.feature:41](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L41)
- [apiGraph/getUser.feature:42](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L42)
- [apiGraph/getUser.feature:143](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L143)
- [apiGraph/getUser.feature:144](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L144)
- [apiGraph/getUser.feature:145](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L145)
- [apiGraph/getUser.feature:146](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L146)
Expand All @@ -117,6 +116,7 @@ The expected failures in this file are from features in the owncloud/ocis repo.
- [apiGraph/getUser.feature:152](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L152)
- [apiGraph/getUser.feature:153](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L153)
- [apiGraph/getUser.feature:154](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L154)
- [apiGraph/getUser.feature:155](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiGraph/getUser.feature#L155)

#### [Sharing to a group with an expiration date does not work #5442](https://github.com/owncloud/ocis/issues/5442)
- [apiSpacesShares/shareSubItemOfSpace.feature:105](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSubItemOfSpace.feature#L105)
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiGraph/assignRole.feature
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api
@api @skipOnStable2.0
Feature: assign role
As an admin,
I want to assign roles to users.
Expand Down
28 changes: 14 additions & 14 deletions tests/acceptance/features/apiGraph/changeOwnPassword.feature
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@
Feature: an user changes its own password


Scenario Outline: change own password
Given user "Alice" has been created with default attributes and without skeleton files
When the user "Alice" changes its own password "<currentPassword>" to "<newPassword>" using the Graph API
Then the HTTP status code should be "<code>"
Examples:
| currentPassword | newPassword | code |
| 123456 | validPass | 204 |
| 123456 | кириллица | 204 |
| 123456 | 密码 | 204 |
| 123456 | ?&^%0 | 204 |
| 123456 | | 400 |
| 123456 | 123456 | 400 |
| wrongPass | 123456 | 400 |
| | validPass | 400 |
Scenario Outline: change own password
Given user "Alice" has been created with default attributes and without skeleton files
When the user "Alice" changes its own password "<currentPassword>" to "<newPassword>" using the Graph API
Then the HTTP status code should be "<code>"
Examples:
| currentPassword | newPassword | code |
| 123456 | validPass | 204 |
| 123456 | кириллица | 204 |
| 123456 | 密码 | 204 |
| 123456 | ?&^%0 | 204 |
| 123456 | | 400 |
| 123456 | 123456 | 400 |
| wrongPass | 123456 | 400 |
| | validPass | 400 |
12 changes: 8 additions & 4 deletions tests/acceptance/features/apiGraph/createUser.feature
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,15 @@ Feature: create user
| withoutPassSameEmail | without pass | alice@example.org | | 200 | true | should |
| name | pass with space | example@example.org | my pass | 200 | true | should |
| nameWithCharacters(*:!;_+-&) | user | new@example.org | 123 | 400 | true | should not |
| withoutEmail | without email | | 123 | 200 | true | should |
| Alice | same userName | new@example.org | 123 | 400 | true | should |
| name with space | name with space | example@example.org | 123 | 400 | true | should not |
| createDisabledUser | disabled user | example@example.org | 123 | 200 | false | should |

@skipOnStable2.0
Examples:
| userName | displayName | email | password | code | enable | shouldOrNot |
| withoutEmail | without email | | 123 | 200 | true | should |
| Alice | same userName | new@example.org | 123 | 400 | true | should |


Scenario: a user cannot be created with empty name
Given the administrator has given "Alice" the role "Admin" using the settings api
Expand Down Expand Up @@ -58,7 +62,7 @@ Feature: create user
| User |
| Guest |

@issue-3516
@issue-3516 @skipOnStable2.0
Scenario: a user cannot be created with the name of the disabled user
Given user "Brian" has been created with default attributes and without skeleton files
And the administrator has given "Alice" the role "Admin" using the settings api
Expand All @@ -71,7 +75,7 @@ Feature: create user
| accountEnabled | true |
Then the HTTP status code should be "400"


@skipOnStable2.0
Scenario: a user can be created with the name of the deleted user
Given user "Brian" has been created with default attributes and without skeleton files
And the administrator has given "Alice" the role "Admin" using the settings api
Expand Down
14 changes: 7 additions & 7 deletions tests/acceptance/features/apiGraph/editUser.feature
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Feature: edit user
| empty mail | | 400 | brian@example.com |
| change to a invalid email | invalidEmail | 400 | brian@example.com |


@skipOnStable2.0
Scenario Outline: the admin user can edit another user's name
Given user "Carol" has been created with default attributes and without skeleton files
When the user "Alice" changes the user name of user "Carol" to "<userName>" using the Graph API
Expand All @@ -43,7 +43,7 @@ Feature: edit user
| change to existing user name | Brian | 409 | Brian |
| empty user name | | 400 | Brian |


@skipOnStable2.0
Scenario: the admin user changes the name of a user to the name of an existing disabled user
Given the user "Alice" has created a new user using the Graph API with the following settings:
| userName | sam |
Expand All @@ -57,7 +57,7 @@ Feature: edit user
| key | value |
| onPremisesSamAccountName | sam |


@skipOnStable2.0
Scenario: the admin user changes the name of a user to the name of a previously deleted user
Given the user "Alice" has created a new user using the Graph API with the following settings:
| userName | sam |
Expand Down Expand Up @@ -207,7 +207,7 @@ Feature: edit user
| Guest | Guest |
| Guest | Admin |


@skipOnStable2.0
Scenario: the admin user disables another user
When the user "Alice" disables user "Brian" using the Graph API
Then the HTTP status code should be "200"
Expand All @@ -217,7 +217,7 @@ Feature: edit user
| displayName | id | mail | onPremisesSamAccountName | accountEnabled |
| Brian Murphy | %uuid_v4% | brian@example.com | Brian | false |


@skipOnStable2.0
Scenario Outline: a normal user should not be able to disable another user
Given user "Carol" has been created with default attributes and without skeleton files
And the administrator has given "Brian" the role "<role>" using the settings api
Expand All @@ -234,7 +234,7 @@ Feature: edit user
| User |
| Guest |


@skipOnStable2.0
Scenario: the admin user enables disabled user
Given the user "Alice" has disabled user "Brian" using the Graph API
When the user "Alice" enables user "Brian" using the Graph API
Expand All @@ -245,7 +245,7 @@ Feature: edit user
| displayName | id | mail | onPremisesSamAccountName | accountEnabled |
| Brian Murphy | %uuid_v4% | brian@example.com | Brian | true |


@skipOnStable2.0
Scenario Outline: a normal user should not be able to enable another user
Given user "Carol" has been created with default attributes and without skeleton files
And the user "Alice" has disabled user "Carol" using the Graph API
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiGraph/getApplications.feature
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @skipOnOcV10
@api @skipOnOcV10 @skipOnStable2.0
Feature: get applications
As an user
I want to be able to get applications information with existings roles
Expand All @@ -25,4 +25,4 @@ Feature: get applications
| Admin |
| Space Admin |
| User |
| Guest |
| Guest |
19 changes: 10 additions & 9 deletions tests/acceptance/features/apiGraph/getUser.feature
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Feature: get users
| Alice |
| Brian |


@skipOnStable2.0
Scenario: admin user gets the information of a user
Given the administrator has given "Alice" the role "Admin" using the settings api
When user "Alice" gets information of user "Brian" using Graph API
Expand Down Expand Up @@ -41,7 +41,7 @@ Feature: get users
| Guest | Guest |
| Guest | Admin |


@skipOnStable2.0
Scenario: admin user gets all users
Given the administrator has given "Alice" the role "Admin" using the settings api
When user "Alice" gets all users using the Graph API
Expand All @@ -51,7 +51,7 @@ Feature: get users
| Alice Hansen | %uuid_v4% | alice@example.org | Alice | true |
| Brian Murphy | %uuid_v4% | brian@example.org | Brian | true |


@skipOnStable2.0
Scenario: admin user gets all users include disabled users
Given the administrator has given "Alice" the role "Admin" using the settings api
And the user "Alice" has disabled user "Brian" using the Graph API
Expand All @@ -74,7 +74,7 @@ Feature: get users
| User |
| Guest |


@skipOnStable2.0
Scenario: admin user gets the drive information of a user
Given the administrator has given "Alice" the role "Admin" using the settings api
When the user "Alice" gets user "Brian" along with his drive information using Graph API
Expand All @@ -93,7 +93,7 @@ Feature: get users
| root@@@webDavUrl | %base_url%/dav/spaces/%space_id% |
| webUrl | %base_url%/f/%space_id% |


@skipOnStable2.0
Scenario Outline: non-admin user gets his/her own drive information
Given the administrator has given "Brian" the role "<userRole>" using the settings api
When the user "Brian" gets his drive information using Graph API
Expand All @@ -117,6 +117,7 @@ Feature: get users
| User |
| Guest |

@skipOnStable2.0
Scenario: admin user gets the group information of a user
Given the administrator has given "Alice" the role "Admin" using the settings api
And group "tea-lover" has been created
Expand Down Expand Up @@ -153,7 +154,7 @@ Feature: get users
| Guest | Guest |
| Guest | Admin |


@skipOnStable2.0
Scenario: admin user gets all users of certain groups
Given the administrator has given "Alice" the role "Admin" using the settings api
And user "Carol" has been created with default attributes and without skeleton files
Expand Down Expand Up @@ -202,7 +203,7 @@ Feature: get users
| displayName | id | mail | onPremisesSamAccountName | accountEnabled |
| Carol King | %uuid_v4% | carol@example.org | Carol | false |


@skipOnStable2.0
Scenario Outline: non admin user tries to get users of certain groups
Given the administrator has given "Alice" the role "Admin" using the settings api
And the administrator has given "Brian" the role "<role>" using the settings api
Expand All @@ -217,7 +218,7 @@ Feature: get users
| User |
| Guest |


@skipOnStable2.0
Scenario: admin user gets all users with certain roles and members of a certain group
Given the administrator has given "Alice" the role "Admin" using the settings api
And user "Carol" has been created with default attributes and without skeleton files
Expand All @@ -243,7 +244,7 @@ Feature: get users
| displayName | id | mail | onPremisesSamAccountName | accountEnabled |
| Carol King | %uuid_v4% | carol@example.org | Carol | true |


@skipOnStable2.0
Scenario Outline: non-admin user tries to get users with a certain role
Given the administrator has given "Alice" the role "<userRole>" using the settings api
When the user "Alice" gets all users with role "<role>" using the Graph API
Expand Down
10 changes: 5 additions & 5 deletions tests/acceptance/features/apiSpaces/spaceManagement.feature
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ Feature: Space management
}
"""


@skipOnStable2.0
Scenario: The space admin user changes the name of the project space
When user "Brian" changes the name of the "Project" space to "New Name" owned by user "Alice"
Then the HTTP status code should be "200"
Expand Down Expand Up @@ -241,7 +241,7 @@ Feature: Space management
}
"""


@skipOnStable2.0
Scenario: The space admin user changes the description of the project space
When user "Brian" changes the description of the "Project" space to "New description" owned by user "Alice"
Then the HTTP status code should be "200"
Expand Down Expand Up @@ -282,7 +282,7 @@ Feature: Space management
}
"""


@skipOnStable2.0
Scenario: The space admin user disables the project space
When user "Brian" disables a space "Project" owned by user "Alice"
Then the HTTP status code should be "204"
Expand Down Expand Up @@ -337,7 +337,7 @@ Feature: Space management
| Brian |
| Carol |


@skipOnStable2.0
Scenario: The space admin user deletes the project space
Given user "Alice" has disabled a space "Project"
When user "Brian" deletes a space "Project" owned by user "Alice"
Expand Down Expand Up @@ -386,7 +386,7 @@ Feature: Space management
}
"""


@skipOnStable2.0
Scenario: The space admin user enables the project space
Given user "Alice" has disabled a space "Project"
When user "Brian" restores a disabled space "Project" owned by user "Alice"
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiSpaces/tag.feature
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @skipOnOcV10
@api @skipOnOcV10 @skipOnStable2.0
Feature: Tag
The user can add a tag to resources for sorting and quick search

Expand Down
Loading

0 comments on commit 270bf06

Please sign in to comment.