This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Make use of the new dynamic navItems feature in phoenix #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
force-pushed
the
dynamic-nav-items
branch
4 times, most recently
from
d7f936f to
82337f1
Compare
refs
approved these changes
Jun 6, 2020
|
Didn't clone the branch, but code lgtm |
kulmann
force-pushed
the
dynamic-nav-items
branch
from
82337f1 to
ff76e17
Compare
Phoenix core now has the ability to add navItems dynamically. With this we can add navItems for the extensions which have at least one settings bundle.
kulmann
force-pushed
the
dynamic-nav-items
branch
from
ff76e17 to
35ccf26
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phoenix core now has the ability to add navItems dynamically. With this
we can add navItems for the extensions which have at least one settings
bundle.