Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Improve documentation to mention new skip tags #347

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Improve documentation to mention new skip tags #347

merged 1 commit into from
Jul 8, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Jul 7, 2020 •
edited
Loading

Description:

This PR mentions new tags: @skipOnOcis-EOS-Storage and @skipOnOcis-OC-Storage in the testing docs

Related Issue:

@jasson99 jasson99 requested a review from individual-it July 7, 2020 07:27
individual-it
individual-it suggested changes Jul 7, 2020
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to add @skipOnOcis-OC-Storage in the command in https://github.com/owncloud/ocis-reva/pull/347/files#diff-5a61e9f9f0b3221e1b12f6e24cf94ed4R85
so that developers can just copy and paste the command

also in https://github.com/owncloud/ocis-reva/pull/347/files#diff-5a61e9f9f0b3221e1b12f6e24cf94ed4R118

@jasson99 jasson99 force-pushed the improveDocsMentionNewTags branch from f2ea4fa to 3312edf Compare July 7, 2020 08:16
@jasson99 jasson99 requested a review from individual-it July 7, 2020 08:16
@jasson99 jasson99 self-assigned this Jul 7, 2020
@jasson99 jasson99 marked this pull request as ready for review July 7, 2020 10:35
@jasson99 jasson99 force-pushed the improveDocsMentionNewTags branch from 80bb48b to 4da2545 Compare July 7, 2020 10:37
individual-it
individual-it suggested changes Jul 7, 2020
View reviewed changes
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
@phil-davis phil-davis requested a review from individual-it July 8, 2020 04:06
phil-davis
phil-davis approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@jasson99 jasson99 force-pushed the improveDocsMentionNewTags branch from b5a31b7 to c35bc3d Compare July 8, 2020 04:09
individual-it
individual-it approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasson99 please rebase and merge

@jasson99 jasson99 force-pushed the improveDocsMentionNewTags branch from c35bc3d to 83d2fe3 Compare July 8, 2020 11:25
@jasson99 jasson99 merged commit fcd3fc2 into master Jul 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the improveDocsMentionNewTags branch July 8, 2020 11:46
ownclouders pushed a commit that referenced this pull request Jul 8, 2020
@jasson99
commit fcd3fc2
b69f9e9 
Merge: 81ffcd4 83d2fe3
Author: jasson99 <[email protected]>
Date:   Wed Jul 8 17:31:42 2020 +0545

    Merge pull request #347 from owncloud/improveDocsMentionNewTags

    Improve documentation to mention new skip tags
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis phil-davis approved these changes

Assignees

@jasson99 jasson99

Labels
QA-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve documentation to mention new skip tags
3 participants
@jasson99 @phil-davis @individual-it