Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sharewithme class #203

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Jan 30, 2024

This ocis-pr 8322 bought changes mentioned below which need refactoring on sharewithme class.

graph/sharedWithMe: return shares for the same resource as a single driveItem

- multiple shares for the same resource are now returned as a single driveItem
- the id for that driveItem is for now based on the resourceId of the shared item
      {sharesstorageproviderid}${sharejailid}!{resourceid of shared item}
- each share is exposed as a separate permission on the remoteId
- the permission now has an invitation property which provides the id of the creator
      of the share
- the client.synchronize flag is now exposed on the top-level driveitem. If at
      least on share of a resource is in accepted state the client.synchronize flag
      will be set to true.
- the UI.Hidden flag is now exposed on the top-level driveitem. If at least on
      share of a resource is marked as hidden the UI.Hidden flag will be set to
      true.
 - the 'shared' property is no longer available (the relevant information from that
      moved to the 'invitation' property of the individual permissions.

DriveItemId not being similar with propfind fileid is fixed by this ocis-pr 8467

Related issue:

@amrita-shrestha amrita-shrestha linked an issue Jan 30, 2024 that may be closed by this pull request
@amrita-shrestha amrita-shrestha force-pushed the bump-ocis-latest-commit-id branch from 45abcc6 to 38d938b Compare January 30, 2024 09:20
@amrita-shrestha amrita-shrestha mentioned this pull request Jan 30, 2024
@amrita-shrestha
Copy link
Contributor Author

amrita-shrestha commented Jan 31, 2024

tests blocked by owncloud/ocis#8331

@individual-it individual-it mentioned this pull request Feb 6, 2024
@amrita-shrestha amrita-shrestha force-pushed the bump-ocis-latest-commit-id branch 4 times, most recently from 866dcc7 to 5f4fb4d Compare February 6, 2024 09:40
@amrita-shrestha amrita-shrestha changed the title [do-not-merge]bump latest ocis commit id Refactor sharewithme class Feb 8, 2024
@amrita-shrestha
Copy link
Contributor Author

amrita-shrestha commented Feb 8, 2024

blocked by owncloud/ocis#8331

added workaround for this issue using constant role id

checked with moodle-repository-ocis ✅ https://github.com/owncloud/moodle-repository_ocis/pull/82/files

@amrita-shrestha amrita-shrestha force-pushed the bump-ocis-latest-commit-id branch from a2403c2 to 93abe40 Compare February 22, 2024 06:17
@amrita-shrestha amrita-shrestha force-pushed the bump-ocis-latest-commit-id branch from 93abe40 to e4f4b89 Compare February 22, 2024 06:35
Copy link

@amrita-shrestha amrita-shrestha marked this pull request as ready for review February 22, 2024 06:39
@amrita-shrestha amrita-shrestha self-assigned this Feb 22, 2024
@individual-it individual-it merged commit 48a9047 into main Feb 26, 2024
2 checks passed
@individual-it individual-it deleted the bump-ocis-latest-commit-id branch February 26, 2024 08:25
ownclouders pushed a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail on latest ocis commit
2 participants