-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCM support #701
Add OCM support #701
Conversation
- added persistant volume (RWO only) - added configmap with configurable providers - added OCIS_ENABLE_OCM to fronend and graph services
- added deployment example
- added OCM_JWT_SECRET
Update PR to lastest |
- added working example deployment
Working now. Ready for review. |
Looks to me like OCM invitations are stored in-memory: owncloud/ocis#10354 @butonic is that true? |
Also I couldn't find out what's wrong when setting |
fixed by enabling persistence in the deployment example: fb4b91b |
I couldn't even do basic testing beyond sharing files: owncloud/ocis#10358 |
will be fixed by adding |
we also need to remove |
By using the latest available oCIS code: diff --git a/deployments/ocm-install/helmfile.yaml b/deployments/ocm-install/helmfile.yaml
index 7336329..e9db100 100644
--- a/deployments/ocm-install/helmfile.yaml
+++ b/deployments/ocm-install/helmfile.yaml
@@ -22,6 +22,9 @@ releases:
chart: ../../charts/ocis
namespace: ocis
values:
+ - image:
+ tag: master
+ sha: 2b7aec0589617869ea6dcb30fbb805fbb93dabb489978a47c77653b8b99ed1bb
- externalDomain: ocis.kube.owncloud.test
- ingress:
enabled: true
@@ -219,6 +222,9 @@ releases:
chart: ../../charts/ocis
namespace: ocis2
values:
+ - image:
+ tag: master
+ sha: 2b7aec0589617869ea6dcb30fbb805fbb93dabb489978a47c77653b8b99ed1bb
- externalDomain: ocis2.kube.owncloud.test
- ingress:
enabled: true I was actually able to share and use shared files via OCM 👍 From my side this PR is in a merge able state when we have a oCIS 6.7.0 rolling release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mergeable when we have a oCIS 6.7.0 rolling release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also works with oCIS 7.0.0-rc.1
Description
This PR adds OCM support.
Related Issue
Motivation and Context
Feature request
How Has This Been Tested?
Go to
deployments/ocm-install
, executehelmfile sync
. Log in to the two systems, select app "ScienceMesh" and create a share on one system and add the invitation to the other system.Types of changes
Checklist:
make docs
) and committed