Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to oCIS 6.1.0 #633

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Jul 11, 2024

Description

Adds events config to proxy service for making oCIS 6.1.0 usable.

Related Issue

Motivation and Context

AFAICT needed since owncloud/ocis@eac5eae and so basically part of #632

How Has This Been Tested?

  • ran the oCIS nats deployment example in minikube and edited some text files

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschmidt thanks for your PR. Please note that the main branch tracks stable oCIS release, currenlty 5.0.5. oCIS 5 doesn't have config option from what I know.

There used to be a next branch that tracks upcoming oCIS versions (prereleases, etc). There will sometime in the future be a next branch that tracks rolling releases.

So this PR needs to either wait until main tracks a stable release of oCIS, that has this option or until next tracks the oCIS rolling releases...

@dschmidt
Copy link
Member Author

Fair enough, thanks for the explanation!

I'll add it to the list in #632

@dschmidt dschmidt mentioned this pull request Jul 11, 2024
6 tasks
@case0sh case0sh mentioned this pull request Jul 11, 2024
16 tasks
@wkloucek wkloucek changed the title feat: add events config to proxy service feat: switch to oCIS 6.1.0 Jul 11, 2024
@wkloucek wkloucek merged commit 5301bec into main Jul 11, 2024
1 check passed
@wkloucek wkloucek deleted the feat/add-events-config-to-proxy-service branch July 11, 2024 12:50
@dschmidt
Copy link
Member Author

🎉

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants