Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to disable SSE #492

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Make it possible to disable SSE #492

merged 3 commits into from
Mar 4, 2024

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented Feb 23, 2024

Description

Make it possible to disable SSE
See #issue-491

Motivation and Context

How Has This Been Tested?

locally on minikube

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside the small layout problem

charts/ocis/values.yaml Outdated Show resolved Hide resolved
@2403905
Copy link
Contributor Author

2403905 commented Feb 26, 2024

@d7oc I added conditional running of the SSE service. Please have a look.

charts/ocis/docs/values.adoc.yaml Outdated Show resolved Hide resolved
@2403905 2403905 requested a review from wkloucek February 27, 2024 10:53
Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micbar micbar dismissed wkloucek’s stale review March 4, 2024 15:16

On vacations

@micbar micbar merged commit d826f7f into owncloud:next Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants