Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0.0 rc.4 #483

Merged
merged 2 commits into from
Feb 12, 2024
Merged

5.0.0 rc.4 #483

merged 2 commits into from
Feb 12, 2024

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Feb 12, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • ran this in minikube with the ocis-nats deployment example

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

d7oc
d7oc approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@d7oc d7oc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkloucek wkloucek merged commit 53256b2 into next Feb 12, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the 5.0.0-rc.4 branch February 12, 2024 12:37
@d7oc d7oc mentioned this pull request Mar 5, 2024
Merged
11 tasks
@wkloucek wkloucek mentioned this pull request Mar 18, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7oc d7oc d7oc approved these changes

@case0sh case0sh Awaiting requested review from case0sh

@nazliyanik nazliyanik Awaiting requested review from nazliyanik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @d7oc